Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Axios (plain,plain-wordmark) #1087

Merged

Conversation

JorchCortez
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1056

quick note here that the website for this issue is wrong (if referring to Axios http since the current link given is for a sort of blog page)

Link to prove your SVG is correct and up-to-date.

Axios http website

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'axios' entry: 
- Invalid version name in versions['svg']: 'plain'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['svg']: 'plain-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'plain'. Must match regexp: (original|plain|line)(-wordmark)?
- Invalid version name in versions['font']: 'plain-wordmark'. Must match regexp: (original|plain|line)(-wordmark)?

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Thomas-Boi
Copy link
Member

Don't worry about the check-bot's message for now. We are currently fixing the issue.

@JorchCortez
Copy link
Contributor Author

@Thomas-Boi Thanks, I did saw in another PR that the same error popped so I thought it was the case 😅 If there's any change needed though let me know 👍🏼

@Thomas-Boi
Copy link
Member

Hi @JorchCortez can you rebase this branch off the latest develop? That should fix the peek icon issues.

@JorchCortez
Copy link
Contributor Author

@Thomas-Boi I just did the rebase to latest develop, if there's any other error let me know, worst case scenario I make the changes again 👍🏼

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Mar 24, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution!

@amacado amacado merged commit 24684e5 into devicons:develop Mar 24, 2022
@amacado
Copy link
Member

amacado commented Mar 24, 2022

My mistake: did not squash-merged, @Thomas-Boi is this a big problem?

@Thomas-Boi
Copy link
Member

My mistake: did not squash-merged, @Thomas-Boi is this a big problem?

I don't think so. It all depends on how many commits are there. This one only has 1 commit so it should be fine. Even if there's more than one, the only issue is it makes for a cluttered history but no problem with our pipeline.

@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants