Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: cypressio (original, original-wordmark) #1097

Merged
merged 4 commits into from
Mar 25, 2022

Conversation

jusuchin85
Copy link
Contributor

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #223

Link to prove your SVG is correct and up-to-date.

https://github.com/cypress-io/cypress-icons

@jusuchin85 jusuchin85 changed the title Add cypress.io icons new icon: cypressio (plain, plain-wordmark) Mar 24, 2022
@Thomas-Boi Thomas-Boi added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 24, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Thomas-Boi commented Mar 24, 2022

The reason for the black blob is due to the letters:
image

They are actually white, which means the color will be stripped when converted to a font. This is fixable using Inkscape and cut out the paths. You can see this guide.

EDIT: I'd also recommend changing the version from plain to original since the original icon matches both version. This is helpful for some people when they add the icons in via script. Thank you for your help 👍

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/cypressio/cypressio-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/cypressio/cypressio-plain.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@jusuchin85
Copy link
Contributor Author

Done! Looks ok on IconMoon:
000015_cleanshot_2022-03-24_17 16 34

@jusuchin85 jusuchin85 changed the title new icon: cypressio (plain, plain-wordmark) new icon: cypressio (original, original-wordmark) Mar 24, 2022
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 24, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@jusuchin85
Copy link
Contributor Author

OK peek bot. Check this out! 🤞

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 25, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🚀

@amacado amacado merged commit b2d0373 into devicons:develop Mar 25, 2022
@jusuchin85 jusuchin85 deleted the 223-cypress-icons branch March 25, 2022 10:37
@amacado amacado mentioned this pull request Apr 27, 2022
1 task
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add cypress.io icons

* Rename icons to original and convert strokes to paths

* Forgot to update devicon.json

* Fix original icon once more
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add cypress.io icons

* Rename icons to original and convert strokes to paths

* Forgot to update devicon.json

* Fix original icon once more
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add cypress.io icons

* Rename icons to original and convert strokes to paths

* Forgot to update devicon.json

* Fix original icon once more
@lunatic-fox lunatic-fox mentioned this pull request Dec 9, 2022
1 task
@lunatic-fox lunatic-fox mentioned this pull request Apr 21, 2023
1 task
@canaleal canaleal mentioned this pull request Aug 7, 2023
1 task
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants