add altnames #1165

[Snailedlt]

Double check these details before you open a PR

• PR does not match another non-stale PR currently opened

Features

altNames added. Now users can search for alternative names of icons

This PR closes NONE

This PR closes #1165

Notes

[Snailedlt]

Contributing guidelines have to be updated to account for this before merging to master btw

[amacado]

There are a lot of errors and open questions to discuss before this pull request can be accepted. In addition to my in-line comments: The wiki/readme needs to be improved to explain the altname. 😄

[Snailedlt]

@amacado Thanks for fishing out a lot of errors.
I will take a look at fixing it soon. Might have to redo most of it by hand, since there are so many errors due to rebasing :/

When it comes to updating the wiki, I agree. But should we wait with that until it's released, or do it now?

[amacado]

When it comes to updating the wiki, I agree. But should we wait with that until it's released, or do it now?

Let's wait till it's released.. I've found this pages which needs an update:

• https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository
• https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60

[Snailedlt]

@amacado I fixed all the issues you found, and made some more finishing touches. Take another look when you have time :)

[maltejur]

The actual devicon.json changes look fine to me, it just seems some temporary code changes from you slipped through.

[Snailedlt]

How many maintainers usually need to approve before PRs can be merged to develop?