Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: hibernate (original, original-wordmark, plain, plain-wordmark) #1227

Merged
merged 12 commits into from
Aug 21, 2022
Merged

new icon: hibernate (original, original-wordmark, plain, plain-wordmark) #1227

merged 12 commits into from
Aug 21, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jun 23, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://hibernate.org/

@kilianpaquier kilianpaquier changed the title new icon: hibernate (original, original-wordmark) new icon: hibernate (original, original-wordmark, plain, plain-wordmark) Jun 27, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, this PR has merge conflicts which need to be solved before merging

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this is a brand, and not a technology. So it doesn't meet the requirements for devicons
Screenshot_20220717_164630

@kilianpaquier
Copy link
Contributor Author

@Snailedlt
Copy link
Collaborator

@kilian-paquier
The wikipedia link you sent calls it Hibernate ORM.

Okey, so hibernate is the company/organization name, and hibernate ORM is the product name. But then the product is also called hibernate (quite confusing if you ask me).

So then, shouldn't the name be hibernateorm? We can have hibernate as an alt name too

@kilianpaquier
Copy link
Contributor Author

Hibernate is a framework, it seems to be owned by Red Hat, but it's open source. Hibernate provides functionalities/libraries/tools, such as the hibernate ORM, validator, etc.

All the functionalities come with the same logo.

Here's the GitHub link of hibernate : https://github.com/hibernate

@Snailedlt
Copy link
Collaborator

Yeah, looking at their twitter account it says something like "...hibernate is a suite of open-source projects..."

@Panquesito7 Looks like this is a suite of products (not a single one), do you think it qualifies for devicons?

Snailedlt
Snailedlt previously approved these changes Jul 18, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by me, but will wait for other maintainers to see if they think it's an icon that should be accepted or not.

@devicons/maintainer Please take a look at the comments on this PR

@Snailedlt Snailedlt requested a review from a team July 25, 2022 19:26
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection awaiting triage Awaiting triage from a maintainer labels Jul 28, 2022
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Aug 6, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙇

@Panquesito7 Panquesito7 removed the awaiting triage Awaiting triage from a maintainer label Aug 16, 2022
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Maintainable

@Snailedlt Snailedlt merged commit 85aba97 into devicons:develop Aug 21, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1227)

* new icon: hibernate (original, original-wordmark)

* hibernate| added plain, plain-wordmark versions

* hibernate| removed plain versions from svg

* hibernate| changed primary color from hibernate logo

* hibernate| optimize plain svg's

* hibernate| moved object in devicon.json

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1227)

* new icon: hibernate (original, original-wordmark)

* hibernate| added plain, plain-wordmark versions

* hibernate| removed plain versions from svg

* hibernate| changed primary color from hibernate logo

* hibernate| optimize plain svg's

* hibernate| moved object in devicon.json

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…rk) (devicons#1227)

* new icon: hibernate (original, original-wordmark)

* hibernate| added plain, plain-wordmark versions

* hibernate| removed plain versions from svg

* hibernate| changed primary color from hibernate logo

* hibernate| optimize plain svg's

* hibernate| moved object in devicon.json

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: David Leal <halfpacho@gmail.com>
@kilianpaquier kilianpaquier deleted the hibernate branch October 19, 2022 19:56
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants