new icon: angular (original, original-wordmark, plain, plain-wordmark) #1240

gabrielfins · 2022-06-28T03:39:43Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #991

Link to prove your SVG is correct and up-to-date.

https://angular.io/presskit

Panquesito7

Hey! Thanks for submitting a PR.
Could you please revert the formatting changes and make another PR for that?

Let us know if you need any help. Thanks. 😄

__
Summary: 🛠️ This code needs a fix | Tags: Not maintainable

kilianpaquier · 2022-06-28T20:23:43Z

devicon.json

+        "aliases": [
+            {
+                "base": "original",
+                "alias": "plain"
+            }
+        ]


Hello @gabrielfins, if you include a specific plain svg, then you don't need to declare an alias between the original and the plain font.

gabrielfins · 2022-06-29T16:27:42Z

Is it correct now?

kilianpaquier · 2022-06-29T19:23:51Z

Seems good on the devicon.json side.

But I think you need the angular-plain.svg to be a svg with only one <path>.

Can you confirm @Panquesito7 ?

Snailedlt · 2022-07-02T15:20:19Z

@kilian-paquier never heard of that requirement before :O

kilianpaquier · 2022-07-02T15:37:52Z

@Snailedlt My bad then ! The paths are united in the https://github.com/devicons/devicon/wiki/SVG-Standards seemed like the same for me 😁

Snailedlt · 2022-07-02T17:37:32Z

@kilian-paquier Ahh, yes you're right! Hadn't seen that there before :)

Snailedlt

Some small changes needed, also can we add the wordmark logo too?
https://www.vectorlogo.zone/util/preview.html?image=/logos/angular/angular-ar21.svg

This is the wordmark logo they use on their website

Would be nice to have exactly that one, but it's a .png and not a .svg file :/

Snailedlt · 2022-07-02T17:49:11Z

icons/angular/angular-plain.svg

+<?xml version="1.0" encoding="UTF-8"?>
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="128px" height="128px" viewBox="0 0 128 128" version="1.1">
+  <g id="surface1">
+    <path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 55.296875 69.324219 L 72.703125 69.324219 L 64 48.382812 Z M 55.296875 69.324219 "/>
+    <path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 64 15.359375 L 16.332031 32.359375 L 23.601562 95.386719 L 64 117.761719 L 104.398438 95.386719 L 111.667969 32.359375 Z M 93.746094 93.492188 L 82.636719 93.492188 L 76.644531 78.539062 L 51.355469 78.539062 L 45.363281 93.492188 L 34.253906 93.492188 L 64 26.675781 Z M 93.746094 93.492188 "/>
+  </g>
+</svg>


Like is explained here and like @kilian-paquier said already, paths must be united. Meaning you should only have one path node like in this suggestion:

Suggested change

<?xml version="1.0" encoding="UTF-8"?>

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="128px" height="128px" viewBox="0 0 128 128" version="1.1">

<g id="surface1">

<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 55.296875 69.324219 L 72.703125 69.324219 L 64 48.382812 Z M 55.296875 69.324219 "/>

<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 64 15.359375 L 16.332031 32.359375 L 23.601562 95.386719 L 64 117.761719 L 104.398438 95.386719 L 111.667969 32.359375 Z M 93.746094 93.492188 L 82.636719 93.492188 L 76.644531 78.539062 L 51.355469 78.539062 L 45.363281 93.492188 L 34.253906 93.492188 L 64 26.675781 Z M 93.746094 93.492188 "/>

</g>

</svg>

<?xml version="1.0" encoding="UTF-8"?>

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="128px" height="128px" viewBox="0 0 128 128" version="1.1">

<g id="surface1">

<path style=" stroke:none;fill-rule:nonzero;fill:rgb(0%,0%,0%);fill-opacity:1;" d="M 55.296875 69.324219 L 72.703125 69.324219 L 64 48.382812 Z M 55.296875 69.324219 M 64 15.359375 L 16.332031 32.359375 L 23.601562 95.386719 L 64 117.761719 L 104.398438 95.386719 L 111.667969 32.359375 Z M 93.746094 93.492188 L 82.636719 93.492188 L 76.644531 78.539062 L 51.355469 78.539062 L 45.363281 93.492188 L 34.253906 93.492188 L 64 26.675781 Z M 93.746094 93.492188 "/>

</g>

</svg>

Snailedlt · 2022-07-02T17:51:44Z

devicon.json

+        "tags": [
+            "framework"
+        ],


Can we add javascript as a tag here?

Suggested change

"tags": [

"framework"

],

"tags": [

"framework",

"javascript"

],

added wordmark logo (original and plain), changed the plain version to contain only one <path> tag and added "javascript" to the tags in devicon.json

gabrielfins · 2022-07-04T22:24:28Z

Hey y'all, I think all the changes requested are done now. I've added the wordmark logo that @Snailedlt requested and changed the colors to match the one they use in their website. I've also changed the plain version to have only one <path> tag and added the "javascript" tag to the icon object in devicon.json. If it needs any other changes let me know.

Snailedlt

Looks good to me.
Great work! 💯

Panquesito7

Thanks for contributing! 🚀

__
Summary: 🏆 This code is awesome | Tags: Efficient

devicons#1240) * new icon: angular (original, plain) * revert formatting changes * added wordmark version and other changes added wordmark logo (original and plain), changed the plain version to contain only one <path> tag and added "javascript" to the tags in devicon.json

new icon: angular (original, plain)

8223f3b

Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 28, 2022

Panquesito7 requested changes Jun 28, 2022

View reviewed changes

kilianpaquier reviewed Jun 28, 2022

View reviewed changes

revert formatting changes

30d16b4

Snailedlt requested changes Jul 2, 2022

View reviewed changes

added wordmark version and other changes

0478da3

added wordmark logo (original and plain), changed the plain version to contain only one <path> tag and added "javascript" to the tags in devicon.json

gabrielfins changed the title ~~new icon: angular (original, plain)~~ new icon: angular (original, original-wordmark, plain, plain-wordmark) Jul 4, 2022

Snailedlt approved these changes Jul 5, 2022

View reviewed changes

Snailedlt requested a review from Panquesito7 August 5, 2022 19:27

Panquesito7 approved these changes Aug 5, 2022

View reviewed changes

Panquesito7 merged commit e962181 into devicons:develop Aug 5, 2022

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: angular (original, original-wordmark, plain, plain-wordmark) #1240

new icon: angular (original, original-wordmark, plain, plain-wordmark) #1240

gabrielfins commented Jun 28, 2022

Panquesito7 left a comment •

edited

Loading

kilianpaquier Jun 28, 2022

gabrielfins commented Jun 29, 2022

kilianpaquier commented Jun 29, 2022

Snailedlt commented Jul 2, 2022

kilianpaquier commented Jul 2, 2022

Snailedlt commented Jul 2, 2022

Snailedlt left a comment

Snailedlt Jul 2, 2022

Snailedlt Jul 2, 2022

gabrielfins commented Jul 4, 2022

Snailedlt left a comment

Panquesito7 left a comment

new icon: angular (original, original-wordmark, plain, plain-wordmark) #1240

new icon: angular (original, original-wordmark, plain, plain-wordmark) #1240

Conversation

gabrielfins commented Jun 28, 2022

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

Panquesito7 left a comment • edited Loading

Choose a reason for hiding this comment

kilianpaquier Jun 28, 2022

Choose a reason for hiding this comment

gabrielfins commented Jun 29, 2022

kilianpaquier commented Jun 29, 2022

Snailedlt commented Jul 2, 2022

kilianpaquier commented Jul 2, 2022

Snailedlt commented Jul 2, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

Snailedlt Jul 2, 2022

Choose a reason for hiding this comment

Snailedlt Jul 2, 2022

Choose a reason for hiding this comment

gabrielfins commented Jul 4, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment •

edited

Loading