Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: moleculer (original, plain) #1296

Merged
merged 6 commits into from
Jul 29, 2022
Merged

new icon: moleculer (original, plain) #1296

merged 6 commits into from
Jul 29, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 24, 2022 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1300

Link to prove your SVG is correct and up-to-date.

https://moleculer.services/

Snailedlt
Snailedlt requested changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes. I also noticed that they have a few more logos, I'll make an issue so we can discuss further there

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt mentioned this pull request Jul 25, 2022
Closed
1 task
@kilianpaquier @Snailedlt
moleculer| review remarks
4248247 
Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
kilianpaquier
kilianpaquier commented Jul 25, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt requested changes Jul 28, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
@kilianpaquier
Copy link
Contributor Author

@Snailedlt Done. I also updated all my PRs to replace the new object at the right place 🙂

@Snailedlt
Copy link
Collaborator

@Snailedlt Done. I also updated all my PRs to replace the new object at the right place 🙂

Great, you are so damn fast, lol!

Snailedlt
Snailedlt approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for your contribution! 🚀

@Snailedlt Snailedlt merged commit 4c1118c into devicons:develop Jul 29, 2022
@kilianpaquier kilianpaquier deleted the moleculer branch August 18, 2022 17:27
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: moleculer (original, plain) (devicons#1296)
d94b654 
* new icon: moleculer (original, plain)

* moleculer| review remarks

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

* moleculer| added wordmark icon

* moved object in devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: moleculer (original, plain) (devicons#1296)
8620df2 
* new icon: moleculer (original, plain)

* moleculer| review remarks

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

* moleculer| added wordmark icon

* moved object in devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
new icon: moleculer (original, plain) (devicons#1296)
5939d57 
* new icon: moleculer (original, plain)

* moleculer| review remarks

Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

* moleculer| added wordmark icon

* moved object in devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilianpaquier @Snailedlt