Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: cloudflare (plain, plain-wordmark, original, original-wordmark) #1298

Merged
merged 3 commits into from
Jul 26, 2022
Merged

new icon: cloudflare (plain, plain-wordmark, original, original-wordmark) #1298

merged 3 commits into from
Jul 26, 2022

Conversation

BenSouchet
Copy link
Contributor

@BenSouchet BenSouchet commented Jul 25, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR "PARTIALLY" closes #785

Link to prove your SVG is correct and up-to-date.

Taken from the official website https://www.cloudflare.com/
and from the github repo https://github.com/cloudflare/research.cloudflare.com/blob/main/img/cloud.svg

From https://www.cloudflare.com/logo/

@BenSouchet BenSouchet changed the title Add cloudflare icon new icon: cloudflare (original, original-wordmark) Jul 25, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but upon doing some research I found that their official logo kit is different from the one used here. We should probably change to that one, so we get the correct color palette, etc :)

icons/cloudflare/cloudflare-original-wordmark.svg Outdated Show resolved Hide resolved
icons/cloudflare/cloudflare-original.svg Outdated Show resolved Hide resolved
@BenSouchet
Copy link
Contributor Author

Colors codes updated

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but still missing the white color though inside the logo itself, almost there

icons/cloudflare/cloudflare-original-wordmark.svg Outdated Show resolved Hide resolved
icons/cloudflare/cloudflare-original.svg Outdated Show resolved Hide resolved
@BenSouchet
Copy link
Contributor Author

Edited + added the version with the white inside the cloud.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

Perfect!
Clean and concise code, appropriate tags and altnames, and some nice custom plain icons specifically for devicons. Couldn't be better! 🥇

Thanks for another great contribution! 💯

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 26, 2022
@Snailedlt
Copy link
Collaborator

Not sure why, but bot:peek isn't working for this PR :/
Making an issue on it

@BenSouchet
Copy link
Contributor Author

BenSouchet commented Jul 26, 2022

The PR title was not correct, I just updated it

@BenSouchet BenSouchet changed the title new icon: cloudflare (original, original-wordmark) new icon: cloudflare (plain, plain-wordmark, original, original-wordmark) Jul 26, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@Snailedlt
Copy link
Collaborator

The PR title was not correct, I just updated it

Oh, nice catch. Looks good now

@Snailedlt Snailedlt merged commit 4657a76 into devicons:develop Jul 26, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1298)

* Add cloudflare icon

* Change Cloudflare color codes

* Change icons for Cloudflare + add plain & plain-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1298)

* Add cloudflare icon

* Change Cloudflare color codes

* Change icons for Cloudflare + add plain & plain-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…ark) (devicons#1298)

* Add cloudflare icon

* Change Cloudflare color codes

* Change icons for Cloudflare + add plain & plain-wordmark
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants