new icon: norg (original, plain) #1346

dvchoudh · 2022-08-14T19:43:36Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes NONE

Additional Information

Neorg (more specifically its underlying format, norg) is a relatively new file markup format aimed at being a successor to markdown and org.

Link to prove your SVG is correct and up-to-date.

norg-original: https://raw.githubusercontent.com/nvim-neorg/neorg/main/res/neorg.svg
norg-plain: https://raw.githubusercontent.com/BinxDot/devicon/feat-icon/neorg/icons/norg/norg-plain.svg

Fix issue with npm publish script

Build preparation for release v2.15.1

Snailedlt · 2022-08-14T21:29:44Z

Is this the same thing?
https://github.com/nvim-neorg/neorg

If so, maybe this icon could be added too as the original version?
https://github.com/nvim-neorg/neorg/blob/main/res/neorg.svg

dvchoudh · 2022-08-15T06:16:56Z

Hi, thanks for replying!

Is this the same thing?
https://github.com/nvim-neorg/neorg

Yes, it indeed is (should have mentioned that, sorry).

If so, maybe this icon could be added too as the original version?
https://github.com/nvim-neorg/neorg/blob/main/res/neorg.svg

Do you want me to add that icon as the original version, and move the existing one to the plain version? It's my first time contributing here so I'm a bit confused 😅.

Snailedlt · 2022-08-15T07:49:22Z

@BinxDot
Okey :)
Yes please, do that!
Also if there are any wordmark or line versions you can add those as well, but no problem if there aren't any

Update git branch

…eorg

…t-icon/neorg

dvchoudh · 2022-08-15T08:10:05Z

@Snailedlt I have fixed it, please do let me know if I've messed up anything, not too experienced with git haha

Snailedlt

Good start for a first time contribution. devicon.json is only missing alnames as far as I can tell.

As for the icons, they look good, but the code is a bit messy. You should take a look at our SVG Standards, and try to use some of our recommended tools for resizing and optimizing the SVG's.

It might be good for you to go through the overview on submitting icons wiki page for your first contribution too, so you get the full picture :)

Try and do some of the changes, and if you have any trouble, you can always ask me or some other supporter/maintainer to take a look again by requesting a new review :)

devicon.json

dvchoudh · 2022-08-15T16:26:40Z

Sorry for the delay, was busy!

As for the icons, they look good, but the code is a bit messy. You should take a look at our SVG Standards, and try to use some of our recommended tools for resizing and optimizing the SVG's.

As for the icons, I have used Iloveimg to resize (128x128) and svgviewer.dev to optimize both the SVG's. Can you please review everything once again when you have the chance? Thanks!

icons/norg/norg-original.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

Snailedlt

Some minor changes I would make, other than that it looks good 😁
Just one more push and we're there 👌

icons/norg/norg-plain.svg

devicon.json

Update git branch

…eorg

…t-icon/neorg

Snailedlt · 2022-08-15T21:34:14Z

@BinxDot is it just me or is the icon on iconmoon being cut off ever so slightly on the right?

Snailedlt · 2022-08-15T21:40:18Z

@BinxDot is it just me or is the icon on iconmoon being cut off ever so slightly on the right?

Doesn't look like this in the icon you uploaded, so something is happening with icomoon. Try adding in the height parameter again, and see if that helps. If not, I don't think it's a big deal anyways, since it's barely noticable

icons/norg/norg-plain.svg

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

dvchoudh · 2022-08-16T07:29:13Z

Looks like adding the height parameter worked!

Snailedlt · 2022-08-16T09:08:00Z

Looks like adding the height parameter worked!

Yeah! 😁
Still cutting off like a 2 or 3 pixels wide chunk, but it's not noticable unless you look for it, so it's all good :)

dvchoudh · 2022-08-16T09:08:53Z

I've just made the primary color a bit lighter in the devicon.json :)

Snailedlt · 2022-08-16T09:09:51Z

Running bot peek one last time then :)

github-actions · 2022-08-16T09:12:14Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt · 2022-08-16T09:13:47Z

Looks like adding the height parameter worked!

Yeah! grin Still cutting off like a 2 or 3 pixels wide chunk, but it's not noticable unless you look for it, so it's all good :)

This is probably just because of pixelation in the screenshot, the SVG preview on gothub sometimes get cut off in a similar manner

Snailedlt

Looks great! ✔️

Thank you for your contribution! 🚀

Panquesito7

Amazing. Thanks for contributing! 🚀

__
Summary: 🏆 This code is awesome | Tags: Maintainable

* bump npm version to v2.15.1 * feat: add neorg icon * fix: rename neorg to norg * fix: add proper orginal and plain versions * fix: add altnames property in devicon.json * fix: resize and optimize svg's * fix: optimize original version of the svg Co-authored-by: David Leal <halfpacho@gmail.com> * fix: remove unnecessary height option from plain version * fix: use most prevalent color from the original version for the primary color Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * fix: add height option to plain version Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> * fix: make primary color lighter Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Amacado <clemens.bastian@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

amacado and others added 5 commits March 22, 2022 22:31

Merge pull request devicons#1084 from devicons/develop

e7a43b9

Fix issue with npm publish script

bump npm version to v2.15.1

619c806

Merge pull request devicons#1085 from devicons/draft-release

1119b9f

Build preparation for release v2.15.1

feat: add neorg icon

c8e75b4

fix: rename neorg to norg

5fa98e2

dvchoudh changed the title ~~new icon: neorg (original)~~ new icon: norg (original) Aug 14, 2022

Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 15, 2022

dvchoudh and others added 5 commits August 15, 2022 11:56

Merge branch 'devicons:master' into feat-icon/neorg

6f31c57

Merge pull request #1 from BinxDot/develop

a4c1c07

Update git branch

Merge branch 'develop' of github.com:BinxDot/devicon into feat-icon/n…

9ae46ce

…eorg

Merge branch 'feat-icon/neorg' of github.com:BinxDot/devicon into fea…

dcb3f55

…t-icon/neorg

fix: add proper orginal and plain versions

eae5dad

dvchoudh changed the title ~~new icon: norg (original)~~ new icon: norg (original, plain) Aug 15, 2022

Snailedlt requested changes Aug 15, 2022

View reviewed changes

devicon.json Show resolved Hide resolved

dvchoudh added 2 commits August 15, 2022 17:13

fix: add altnames property in devicon.json

6595ecb

fix: resize and optimize svg's

8c144d1

Panquesito7 reviewed Aug 15, 2022

View reviewed changes

icons/norg/norg-original.svg Outdated Show resolved Hide resolved

fix: optimize original version of the svg

aef7b48

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 15, 2022

This comment was marked as outdated.

Sign in to view

Snailedlt requested changes Aug 15, 2022

View reviewed changes

icons/norg/norg-plain.svg Outdated Show resolved Hide resolved

devicon.json Outdated Show resolved Hide resolved

dvchoudh and others added 4 commits August 16, 2022 00:21

Merge pull request #2 from BinxDot/develop

c0e39d1

Update git branch

Merge branch 'develop' of github.com:BinxDot/devicon into feat-icon/n…

2abc5f4

…eorg

Merge branch 'feat-icon/neorg' of github.com:BinxDot/devicon into fea…

15b8077

…t-icon/neorg

fix: remove unnecessary height option from plain version

10d8029

Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 15, 2022

This comment was marked as outdated.

Sign in to view

Snailedlt reviewed Aug 15, 2022

View reviewed changes

icons/norg/norg-plain.svg Outdated Show resolved Hide resolved

fix: add height option to plain version

87cab04

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 16, 2022

This comment was marked as outdated.

Sign in to view

fix: make primary color lighter

95267c0

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 16, 2022

Snailedlt removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 16, 2022

Snailedlt approved these changes Aug 16, 2022

View reviewed changes

Snailedlt requested review from Panquesito7 and amacado August 16, 2022 09:14

Panquesito7 approved these changes Aug 21, 2022

View reviewed changes

Panquesito7 merged commit 52e161e into devicons:develop Aug 21, 2022

pysan3 mentioned this pull request Apr 26, 2023

Any suggestions for web devicons? nvim-neorg/neorg#792

Open

1 task

pysan3 mentioned this pull request Aug 11, 2023

Adding Glyphs or icons Support for Neorg files [nerd fonts] nvim-neorg/neorg#1019

Closed

1 task

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: norg (original, plain) #1346

new icon: norg (original, plain) #1346

dvchoudh commented Aug 14, 2022 •

edited

Loading

Snailedlt commented Aug 14, 2022

dvchoudh commented Aug 15, 2022 •

edited

Loading

Snailedlt commented Aug 15, 2022

dvchoudh commented Aug 15, 2022

Snailedlt left a comment

dvchoudh commented Aug 15, 2022 •

edited

Loading

This comment was marked as outdated.

Snailedlt left a comment

This comment was marked as outdated.

Snailedlt commented Aug 15, 2022

Snailedlt commented Aug 15, 2022

This comment was marked as outdated.

dvchoudh commented Aug 16, 2022

Snailedlt commented Aug 16, 2022 •

edited

Loading

dvchoudh commented Aug 16, 2022

Snailedlt commented Aug 16, 2022

github-actions bot commented Aug 16, 2022

Snailedlt commented Aug 16, 2022

Snailedlt left a comment

Panquesito7 left a comment •

edited

Loading

new icon: norg (original, plain) #1346

new icon: norg (original, plain) #1346

Conversation

dvchoudh commented Aug 14, 2022 • edited Loading

Double check these details before you open a PR

Additional Information

Link to prove your SVG is correct and up-to-date.

Snailedlt commented Aug 14, 2022

dvchoudh commented Aug 15, 2022 • edited Loading

Snailedlt commented Aug 15, 2022

dvchoudh commented Aug 15, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

dvchoudh commented Aug 15, 2022 • edited Loading

This comment was marked as outdated.

Snailedlt left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Snailedlt commented Aug 15, 2022

Snailedlt commented Aug 15, 2022

This comment was marked as outdated.

dvchoudh commented Aug 16, 2022

Snailedlt commented Aug 16, 2022 • edited Loading

dvchoudh commented Aug 16, 2022

Snailedlt commented Aug 16, 2022

github-actions bot commented Aug 16, 2022

Snailedlt commented Aug 16, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment • edited Loading

Choose a reason for hiding this comment

dvchoudh commented Aug 14, 2022 •

edited

Loading

dvchoudh commented Aug 15, 2022 •

edited

Loading

dvchoudh commented Aug 15, 2022 •

edited

Loading

Snailedlt commented Aug 16, 2022 •

edited

Loading

Panquesito7 left a comment •

edited

Loading