Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: materializecss (original, plain) #1363

Merged
merged 21 commits into from
Dec 10, 2022
Merged

new icon: materializecss (original, plain) #1363

merged 21 commits into from
Dec 10, 2022

Conversation

AbdelrahmanDwedar
Copy link
Contributor

@AbdelrahmanDwedar AbdelrahmanDwedar commented Aug 24, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1345

Link to prove your SVG is correct and up-to-date.

https://materializecss.github.io/materialize/res/materialize.svg

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 24, 2022
@AbdelrahmanDwedar
Copy link
Contributor Author

It's my first time contributing here, so I'm not quite sure if 100% of things are actually right.

@AbdelrahmanDwedar AbdelrahmanDwedar changed the title new icon: MAterializecss (original) new icon: Materializecss (original) Aug 24, 2022
@AbdelrahmanDwedar
Copy link
Contributor Author

Oops I added the changes in AbdelrahmanDwedar:master and merged by accident!! 😵‍💫

That's embarrassing, sorry.

@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 changed the title new icon: Materializecss (original) new icon: materializecss (original) Aug 24, 2022
@github-actions

This comment was marked as outdated.

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions

This comment was marked as outdated.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Could you please follow the steps/address what the bot mentioned earlier?
Let us know if you need any help with that here in our Discord community. 🙂

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not maintainable

@AbdelrahmanDwedar
Copy link
Contributor Author

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier?
Let us know if you need any help with that here in our Discord community. 🙂

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not maintainable

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

@Panquesito7
Copy link
Member

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier?
Let us know if you need any help with that here in our Discord community. 🙂
__

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

You just need to make a file named materializecss-plain.svg and set all the colors to one simple color. In this case, we can use #EB7077, which is the main color of the icon set in devicon.json.

Let us know if you need any help! Thank you. 🙂

@AbdelrahmanDwedar
Copy link
Contributor Author

I'm very sorry for the late response, I was (and still) out of internet, it'll get better next week hopefully, and the I'll continue everything needed.

Hey there! Could you please follow the steps/address what the bot mentioned earlier?
Let us know if you need any help with that here in our Discord community. slightly_smiling_face
__

I actually don't quite know how to make that icon plain, is there any recommended application or web app that could be used for that or I may just edit fhe svg file's code to set all the colors to only one?

You just need to make a file named materializecss-plain.svg and set all the colors to one simple color. In this case, we can use #EB7077, which is the main color of the icon set in devicon.json.

Let us know if you need any help! Thank you. slightly_smiling_face

I've added the requested changes, inform me if there's anything else missing.
And thanks for helping. 🤝

@Panquesito7 Panquesito7 changed the title new icon: materializecss (original) new icon: materializecss (original, plain) Sep 12, 2022
@github-actions

This comment was marked as outdated.

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@AbdelrahmanDwedar
Copy link
Contributor Author

Is there anything left?

@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Sep 13, 2022
@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 14, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the paths have been merged, and it was moved to the correct position in devicon.json, which is great!

I noticed however that the icon is quite small, and there's a lot of whitespace now. Could you make the icons fill the width of the viewbox please?
image

@AbdelrahmanDwedar
Copy link
Contributor Author

I resized it as requested please inform me if there's something else need to fix or check out.

Also about the little tiny gap between figures in the plain version I think it makes more sense to leave as it gives you idea about the logo more. I think that gaps was already in the original one too but wasn't appearing as there's different colors in it.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look good visually now imo, great work!

Only thing left to do is minimize the icons, which can be done by following this guide: #1306 (comment)

I can do it if you want, just let me know

@AbdelrahmanDwedar
Copy link
Contributor Author

I guess that's all, not sure if I should also follow the next message after it. Is it necessary in out case or just there?

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to check some options. I see there's no viewbox, please read the guide I linked again, and make sure you check the options like the guide says :)

Ohh, and the comment below can be ignored, SVGOMG does a good enough job :)

@AbdelrahmanDwedar
Copy link
Contributor Author

I see, I'll fix it now

@AbdelrahmanDwedar
Copy link
Contributor Author

Is that all?

@Snailedlt
Copy link
Collaborator

Yeah, looks like that's all :)
Just gonna run some checks to see before approving 👍

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 22, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Nov 22, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for a great contribution! Hope to see more PRs from you 💯

@lunatic-fox lunatic-fox added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Nov 22, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some modifications, removing some hairlines. Hope that's ok! 🙂
Approved! ✔
Thank for this contribution! 🚀

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Nov 22, 2022

Besides, seem that their SVG logo have some issues though. 🤔

@Snailedlt Snailedlt merged commit 32afd1f into devicons:develop Dec 10, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants