Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: vyper (original, original-wordmark, plain, plain-wordmark) #1401

Merged
merged 4 commits into from
Oct 11, 2022
Merged

new icon: vyper (original, original-wordmark, plain, plain-wordmark) #1401

merged 4 commits into from
Oct 11, 2022

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #954

Link to prove your SVG is correct and up-to-date.

https://raw.githubusercontent.com/vyperlang/vyper/master/logo/vyper-logo-transparent.svg

@Snailedlt Snailedlt added request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection and removed request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue labels Oct 1, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
Snailedlt
Snailedlt requested changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just missing an altname for vyperlang and it's complete imo.

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox @Snailedlt
Update devicon.json
62d42cb 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
Snailedlt previously approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️
Thanks for your contribution!

@Snailedlt Snailedlt requested review from a team, amacado and Panquesito7 and removed request for a team October 2, 2022 16:31
Panquesito7
Panquesito7 reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add original-wordmark or plain-wordmark versions?

devicon.json Show resolved Hide resolved
@lunatic-fox
Add new icons
30a310a 
Add `original-wordmark` and `plain-wordmark` icons.
Snailedlt
Snailedlt requested changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you scale up the icons so they fit the height or width exactly? There's a lot of wiggleroom now which isn't good when displayed next to other icons.

Edit:
Only the wordmark icons need to be scaled to fit the y or x dimension

@lunatic-fox
Copy link
Contributor Author

lunatic-fox commented Oct 6, 2022 •
edited
Loading

I see.
No problem!
All done!

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks awesome! Great work @lunatic-fox 💯

Panquesito7
Panquesito7 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks! 🚀

@Panquesito7 Panquesito7 changed the title new icon: vyper (original, plain) new icon: vyper (original, original-wordmark, plain, plain-wordmark) Oct 11, 2022
@Panquesito7 Panquesito7 merged commit 07e9ef8 into devicons:develop Oct 11, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt
new icon: vyper (original, original-wordmark, plain, plain-wordmark) (d…
aa04b44 
…evicons#1401)

* Add Vyper

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Add new icons

Add `original-wordmark` and `plain-wordmark` icons.

* Resize icons

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt
new icon: vyper (original, original-wordmark, plain, plain-wordmark) (d…
70a7a40 
…evicons#1401)

* Add Vyper

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Add new icons

Add `original-wordmark` and `plain-wordmark` icons.

* Resize icons

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt
new icon: vyper (original, original-wordmark, plain, plain-wordmark) (d…
ed738da 
…evicons#1401)

* Add Vyper

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Add new icons

Add `original-wordmark` and `plain-wordmark` icons.

* Resize icons

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@lunatic-fox lunatic-fox deleted the add_vyper branch June 1, 2023 12:28
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lunatic-fox @Snailedlt @Panquesito7