Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: cairo (original, plain, original-wordmark, plain-wordmark) #1408

Merged
merged 4 commits into from
Oct 11, 2022
Merged

new icon: cairo (original, plain, original-wordmark, plain-wordmark) #1408

merged 4 commits into from
Oct 11, 2022

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1378

Link to prove your SVG is correct and up-to-date.

https://www.cairographics.org/cairo-banner.png

@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 2, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
Snailedlt
Snailedlt previously approved these changes Oct 2, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to add the altname or not. Couldn't find it any other place than on their website, but I guess it makes searching easier anyways? I dunno, up to you

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox @Snailedlt
Update devicon.json
32aca63 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
Snailedlt previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt Snailedlt requested review from a team, amacado and Panquesito7 and removed request for a team October 3, 2022 07:33
@lunatic-fox
Copy link
Contributor Author

I think I made a mistake on this one since Cairo graphics already have .svg files to work on:

I made the icons based on a .png file of their logo.
https://www.cairographics.org/cairo-banner.png

And in those files the logo have a totally different color pattern.

In order to fix it I'll make an icon bringing their .svg files to their website current color pattern.
(pale blue scarabs) > (yellow scarabs)

I think this is more accurate, because keep the icon original nodes. And because their .svg files are from 2005 and on their website they are using the style I've picked and the latest version of the software is from 2020.

Before my commit I wanna be sure if everything is ok.

@Snailedlt
Copy link
Collaborator

@lunatic-fox Sounds good to me. Feel free to go ahead with the change

@lunatic-fox
Copy link
Contributor Author

Updates done!

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✔️
Liked the old one better personally, but this is more accurate to their current logo, so I think we should keep this one 💯

@Snailedlt
Copy link
Collaborator

Snailedlt commented Oct 3, 2022 •
edited

@lunatic-fox
Great work! 🥇
Thanks for your contribution again, you've been on 🔥fire🔥 this past week!

@lunatic-fox
Copy link
Contributor Author

Looks good! ✔️ Liked the old one better personally, but this is more accurate to their current logo, so I think we should keep this one 💯

Me too! 😅

Panquesito7
Panquesito7 reviewed Oct 6, 2022
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@lunatic-fox @Panquesito7
Update devicon.json
7813757 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit cca56f6 into devicons:develop Oct 11, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt @Panquesito7
new icon: cairo (original, plain, original-wordmark, plain-wordmark) (d…
dbe1dab 
…evicons#1408)

* Add Cairo

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update Cairo icons

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt @Panquesito7
new icon: cairo (original, plain, original-wordmark, plain-wordmark) (d…
a1c5e3a 
…evicons#1408)

* Add Cairo

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update Cairo icons

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@lunatic-fox @Snailedlt @Panquesito7
new icon: cairo (original, plain, original-wordmark, plain-wordmark) (d…
14307bf 
…evicons#1408)

* Add Cairo

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update Cairo icons

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: Jørgen Kalsnes Hagen <Snailedlt@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@lunatic-fox lunatic-fox deleted the add_cairo branch June 1, 2023 12:28
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@amacado amacado Awaiting requested review from amacado

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lunatic-fox @Snailedlt @Panquesito7