Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: bun (original) #1462

Merged
merged 2 commits into from
Dec 12, 2022
Merged

new icon: bun (original) #1462

merged 2 commits into from
Dec 12, 2022

Conversation

AmreshSinha
Copy link
Contributor

@AmreshSinha AmreshSinha commented Oct 15, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1282

Link to prove your SVG is correct and up-to-date.

https://github.com/oven-sh/bun/blob/main/packages/bun-landing/public/logo.svg

Additional Comments

There was no svg of wordmark and plain type in their original repository.

@Snailedlt Snailedlt self-requested a review October 19, 2022 13:23
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 19, 2022
@AmreshSinha
Copy link
Contributor Author

Bump.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon itself looks good, but since it's multi-colored it can't be used as a font. So either remove original from the font array, or add a new mono-colored (plain or line) icon which can be used as a font :)

devicon.json Outdated Show resolved Hide resolved
@Snailedlt
Copy link
Collaborator

@AmreshSinha Do you want to make a plain or line version of this icon?
You can follow this guide for making a line icon: #1306 (comment)

If you don't want to, that's okey too :) We can ask someone else

@AmreshSinha
Copy link
Contributor Author

AmreshSinha commented Nov 8, 2022

The icon itself looks good, but since it's multi-colored it can't be used as a font. So either remove original from the font array, or add a new mono-colored (plain or line) icon which can be used as a font :)

I'll do these changes today😅 I was afk for some days.

@AmreshSinha Do you want to make a plain or line version of this icon?

You can follow this guide for making a line icon: #1306 (comment)

If you don't want to, that's okey too :) We can ask someone else

I can't think of the main color in this main logo for the plain one. :/ It would be very helpful if anyone can co-author this pr with a plain or line version.

@Snailedlt
Copy link
Collaborator

@lunatic-fox or @kilianpaquier
Any of you wanna make some plain and line versions of this icon?

@kilianpaquier
Copy link
Contributor

@lunatic-fox or @kilianpaquier
Any of you wanna make some plain and line versions of this icon?

Hello, I can take a look next Saturday

@kilianpaquier
Copy link
Contributor

@lunatic-fox or @kilianpaquier
Any of you wanna make some plain and line versions of this icon?

Hello, I can take a look next Saturday

Hello, here's a proposition for the bun original icon.

bun-original (1)

@lunatic-fox
Copy link
Contributor

Hi @kilianpaquier!
The version you're making actually is the plain one. 🙂
I thought in something that way:

It's not a SVG

Like preserving the mouth contour and no fill.

PS: I don't know why, probably a bug from my side since it works fine in other programs, but when I try to visualize from browser this happens:

This is just a thing that I want to share. Don't need to worry about it. 😀

@kilianpaquier
Copy link
Contributor

kilianpaquier commented Nov 25, 2022

Hi @kilianpaquier! The version you're making actually is the plain one. 🙂 I thought in something that way:

It's not a SVG

Like preserving the mouth contour and no fill.

PS: I don't know why, probably a bug from my side since it works fine in other programs, but when I try to visualize from browser this happens:

This is just a thing that I want to share. Don't need to worry about it. 😀

Hello ! Yes obviously I didn’t write the correct word 😂.

Thanks for the feedback, I see it with the right color on my phone, but I’m gonna take a look at the attributes just to be sure.

Great idea for the line icon, I shouldn’t take me long tonight to draft it.

@kilianpaquier
Copy link
Contributor

Hello,

I fixed the plain with the fill attribute instead of style. Plus here's also the line icon.

bun-plain
bun-line

@lunatic-fox
Copy link
Contributor

Pretty good! 🤩
I think the only thing that's needed is to keep the little tongue contour on plain version.

@Snailedlt
Copy link
Collaborator

@lunatic-fox feel free to add the plain and line icons to the PR. Like you said, the plain version needs the tongue added back in :)

@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 11, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit aeeb4b4 into devicons:develop Dec 12, 2022
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants