Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: consul (original, original-wordmark, plain-wordmark) #1604

Merged
merged 8 commits into from
Jan 27, 2023

Conversation

luizcarloscf
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1603

Link to prove your SVG is correct and up-to-date.

Project Homepage
HashiCorp Brand Guidelines
Logo

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there!
Since original version is already a monochromatic icon I took the liberty to remove plain version and aliased original as plain in devicon.json. Hope that's ok! 😁

I also suggesting two more tags security and tool.

You've made a great pull request! 🚀

devicon.json Outdated Show resolved Hide resolved
@lunatic-fox lunatic-fox added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 8, 2023
@luizcarloscf
Copy link
Contributor Author

Hey @lunatic-fox, I think I added all the requested changes. Also, the suggestions you made about original version being already a monochromatic icon and making alias of original as plain in devicon.json apply to another PR that I made #1609.

I've dedicated myself to contributing good quality icons, is there anything that could be better?

lunatic-fox
lunatic-fox previously approved these changes Jan 8, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @luizcarloscf, perfect catch on your other PR.

Well, I think you're already doing a great job. If you want to get more specific info you can take a look at SVG Versions and Updating devicon.json wiki topics.

There's also the Devicon Discord server.

A little thing about GitHub is that is possible to commit someone's suggestion this way:

Thank you for this contribution! ✔🚀

devicon.json Outdated Show resolved Hide resolved
@Snailedlt
Copy link
Collaborator

Hey @lunatic-fox, I think I added all the requested changes. Also, the suggestions you made about original version being already a monochromatic icon and making alias of original as plain in devicon.json apply to another PR that I made #1609.

I've dedicated myself to contributing good quality icons, is there anything that could be better?

The icons are excellent! 💯

I think the only thing to make them better is to add a new line at the end of each file, since it's needed for some older text editors and IDE's.
See this warning:
image

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
- Add newline at the end of each file
- Scale icons to fit in viewbox
@Snailedlt Snailedlt removed the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 9, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizing looks good, however there are now two newlines instead of one at the end of each file. It's a bit confusing since GitHub automatically hides the last newline, but if you edit the file, you'll see that there are 2 empty lines at the end.

So make sure there's only one newline at the end of each file :)

devicon.json Outdated Show resolved Hide resolved
@luizcarloscf
Copy link
Contributor Author

luizcarloscf commented Jan 9, 2023

That's kind odd, I opened with a text editor and I saw only two lines in the SVG files. I will check this...

luizcarloscf and others added 2 commits January 9, 2023 20:48
Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
@luizcarloscf
Copy link
Contributor Author

I opened the icon files with vim and use the command :set list to display tabs and newline characters.
I hope that everything is fine now 😃

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! ✔
Thank you for this great contribution! 🚀

@lunatic-fox lunatic-fox changed the title new icon: consul (original, original-wordmark, plain, plain-wordmark) new icon: consul (original, original-wordmark, plain-wordmark) Jan 27, 2023
@Snailedlt Snailedlt added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 27, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt
Copy link
Collaborator

Thanks for another great PR, and thank you for making our review process easy by having high quality PR's!

@Snailedlt Snailedlt merged commit caaff34 into devicons:develop Jan 27, 2023
@luizcarloscf luizcarloscf deleted the 1603-consul-icons branch May 21, 2023 00:32
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants