Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: intellij (original, plain) #1635

Closed
wants to merge 6 commits into from

Conversation

snglenote
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format update icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here

This PR contributes to #1293

Link to prove your SVG is correct and up-to-date.

https://www.jetbrains.com/idea/

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I stated here in your previous PR. These icons have already been updated on the develop branch, and thus don't need to be updated again. The icons will be available on the website and npm when we make our next release

@Snailedlt
Copy link
Collaborator

Also worth noting that the branch should be based on develop instead of master, so you don't get all those extra bump and merge commits :)

@Snailedlt Snailedlt closed this Jan 19, 2023
@Snailedlt
Copy link
Collaborator

@snglenote they look the same to me: https://github.com/devicons/devicon/tree/develop/icons%2Fintellij

Could you tell me what the difference is?

@snglenote
Copy link
Author

i was looking at the wrong thing lol im so sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants