Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: grpc (original, plain) #1763

Merged
merged 2 commits into from
May 20, 2023
Merged

new icon: grpc (original, plain) #1763

merged 2 commits into from
May 20, 2023

Conversation

ConX
Copy link
Contributor

@ConX ConX commented May 17, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #467

This is a resubmission of #1751 that got accidentally deleted

Link to prove your SVG is correct and up-to-date.

https://grpc.io/img/logos/grpc-logo.png

@ConX
New icon grpc
0df3927 
Recreating deleted PR head branch
@ConX ConX added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 17, 2023
@ConX ConX added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label May 17, 2023
Panquesito7
Panquesito7 approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit f6f89aa into devicons:develop May 20, 2023
4 checks passed
@ConX ConX deleted the new-icon-grpc branch May 20, 2023 20:57
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ConX @Panquesito7