Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: reactrouter (original, original-wordmark, plain, plain-wordmark) #1765

Merged
merged 7 commits into from
May 23, 2023
Merged

new icon: reactrouter (original, original-wordmark, plain, plain-wordmark) #1765

merged 7 commits into from
May 23, 2023

Conversation

Gautam25Raj
Copy link
Contributor

  • Add reactrouter icons

  • Update devicon.json

@Gautam25Raj
new icon: reactrouter (reactrouter-original, reactrouter-original-wor…
324729d 
…dmark, reactrouter-plain, reactrouter-plain-wordmark)

* Add reactrouter icons

* Update devicon.json
@ConX ConX added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 18, 2023
@Gautam25Raj Gautam25Raj changed the base branch from master to develop May 18, 2023 15:32
Panquesito7
Panquesito7 requested changes May 20, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Gautam25Raj
Update devicon.json
d071253 
* Remove alt text

* Update font version
Panquesito7
Panquesito7 requested changes May 21, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 previously approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

image

image

@lunatic-fox
Fixes
36069f3 
- Add comma to split items of `tags` in `devicon.json`.
- Remove `height` and `width` and replace by `viewBox`.
- Remove fill color from plain versions.
@lunatic-fox
Copy link
Contributor

Just to be extra sure after the modification.
Color #f44250 will be added by color property of devicon.json.

lunatic-fox
lunatic-fox approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

@Panquesito7 Panquesito7 merged commit 3ceb1f0 into devicons:develop May 23, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gautam25Raj @lunatic-fox @Panquesito7 @ConX