Update codeql-analysis to run on .github #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConX
added
bug
Panquesito7
reviewed
May 18, 2023
Co-authored-by: David Leal <halfpacho@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-check these details before you open a PR
Features
It appears that by default codeql does not look into the
.githubdirectory, and as a result, all executions fail as python is listed, but no.pyscripts exist outside that hidden directory.To address this, this PR splits the codeql initialization and analysis into three parallel jobs, one for javascript, one for python that runs in
.github/, one optional python for the rest in case we later add python scripts outside the.github/directory.Here are some screenshots from the testing:
Successful execution of all codeql analysis jobs.
Log that shows that the Python is skipped since there are no files there
This PR closes NONE
Notes