Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: framework7 (original, original-wordmark) #1785

Merged
merged 22 commits into from
Jun 11, 2023
Merged

new icon: framework7 (original, original-wordmark) #1785

merged 22 commits into from
Jun 11, 2023

Conversation

dotarjun
Copy link
Contributor

@dotarjun dotarjun commented Jun 3, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

#1776

Link to prove your SVG is correct and up-to-date.

https://framework7.io/

@dotarjun dotarjun changed the title new icon: framework7 (original,plain) new icon: framework7 (original,plain,original-wordmark, plain-wordmark) Jun 3, 2023
@dotarjun dotarjun changed the title new icon: framework7 (original,plain,original-wordmark, plain-wordmark) new icon: framework7 (original, plain, original-wordmark, plain-wordmark) Jun 3, 2023
Gautam25Raj
Gautam25Raj suggested changes Jun 3, 2023
View reviewed changes
devicon.json Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/framework7/framework-plain.svg Outdated Show resolved Hide resolved
icons/framework7/framework-original-wordmark.svg Outdated Show resolved Hide resolved
icons/framework7/framework-plain-wordmark.svg Outdated Show resolved Hide resolved
@Gautam25Raj
Copy link
Contributor

Maybe we don't need this plain version. Both plain and original have single color. What do you think? 🤔

@dotarjun
Copy link
Contributor Author

dotarjun commented Jun 3, 2023

agreed

dotarjun and others added 3 commits June 4, 2023 00:18
@dotarjun
remove plain versions
29b5fbe
@dotarjun
Add aliases and remove plain, plain-wordmark versions
a2b5297
@lunatic-fox
Add newline and some fixes:
9e50a5b 
- Rename icons from "framework-[version].svg" to "framework7-[version].svg".
- Remove "style" attribute from `original` version.
- Remove trailing comma in `devicon.json`.
@lunatic-fox lunatic-fox changed the title new icon: framework7 (original, plain, original-wordmark, plain-wordmark) new icon: framework7 (original, original-wordmark) Jun 4, 2023
lunatic-fox
lunatic-fox previously approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are great! ✔
Thank you for contributing! 🚀

dotarjun
dotarjun commented Jun 4, 2023
View reviewed changes
Copy link
Contributor Author

@dotarjun dotarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep on missing these minor intricacies haha

@Gautam25Raj
Copy link
Contributor

I keep on missing these minor intricacies haha

Same for me. 😆

Gautam25Raj
Gautam25Raj previously approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Contribution. 🚀

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 4, 2023
Panquesito7
Panquesito7 reviewed Jun 4, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@dotarjun dotarjun dismissed stale reviews from Gautam25Raj and lunatic-fox via 3b063ae June 5, 2023 05:35
@gustavoSutil
Copy link

thank you, guys!

Panquesito7
Panquesito7 approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks! 🚀

@Panquesito7 Panquesito7 merged commit c229e7c into devicons:develop Jun 11, 2023
4 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Gautam25Raj Gautam25Raj Gautam25Raj approved these changes

@lunatic-fox lunatic-fox lunatic-fox approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotarjun @Gautam25Raj @gustavoSutil @Panquesito7 @lunatic-fox