Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: tableau (original, original-wordmark, plain, plain-wordmark) #1811

Closed
wants to merge 5 commits into from

Conversation

Gautam25Raj
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1030

Link to prove your SVG is correct and up-to-date.

https://www.tableau.com/about/media-download-center
https://cdnl.tblsft.com/sites/default/files/pages/tableau_cmyk_2015.png

Gautam25Raj and others added 2 commits June 26, 2023 20:33
- Unify paths that share the same properties on `original` version
- Ungroup `plain-wordmark` version
- Resize all versions to 128px
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 3, 2023
devicon.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated devicon.json

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thank you! 🚀

image

image

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔️
Thank you for this contribution! 🚀

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow this icon @Panquesito7?
I think this is a case of a CRM tool: Wiki

@lunatic-fox lunatic-fox added the discussion Use this label for community discussions about changes/features/.. label Jul 4, 2023
@Panquesito7
Copy link
Member

You're right. The Wiki specifically states "Salesforces", and Tableu appears to be a product from them.
I'll be closing this PR for now. We can still discuss further about the icon addition.

Thank you for your contributions. 🙂

@Panquesito7 Panquesito7 added the wontfix This will not be worked on label Jul 21, 2023
@canaleal canaleal mentioned this pull request Apr 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Use this label for community discussions about changes/features/.. feature:icon Use this label for pull requests when a new icon is ready to be added to the collection wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants