Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: ngrok (original, line) #1891

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

canaleal
Copy link
Contributor

@canaleal canaleal commented Oct 7, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1801

Link to prove your SVG is correct and up-to-date.

Website Brand: https://ngrok.com/brand
Github: https://github.com/ngrok

Notes

The Ngrok website offers a variety of SVG icons, but their preferred one is the blue 'ngrok' icon with the color #02228e.
Ngrok does make use of a smaller icon n as shown in the brands page, but this is only used for the favicon and literally nowhere else.

Given the original icon's simplicity and single color, I set the terms plain, plain-wordmark, and original-wordmark as aliases with the base being "original".

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths need to be unified since it's an alias for the plain and plain-wordmark versions.
Excellent use of aliases btw!

Snailedlt
Snailedlt previously approved these changes Oct 22, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Oct 30, 2023
@canaleal canaleal changed the title new icon: ngrok (original) new icon: ngrok (original, line) Nov 1, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! And perfect use of aliases! 💯
Thank you for this contribution! 🚀

@canaleal canaleal requested a review from weh June 15, 2024 22:28
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 5c33758 into devicons:develop Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants