Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: carbon (original) #1899

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 10, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes
closes #1895

Link to prove your SVG is correct and up-to-date.

https://github.com/carbon-language/carbon-lang

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another great contribution! 💯 🙇
Again, I just suggested a small change for the icon, once that's added it's all good!

icons/carbon/carbon-original.svg Outdated Show resolved Hide resolved
weh and others added 2 commits October 22, 2023 15:18
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@weh weh force-pushed the feature/1895-add-carbon-icon branch from 8bdd8ef to 6bdb840 Compare October 22, 2023 13:18
@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another great PR @weh! 💯
Looking forward to the next one 🚀

@Snailedlt Snailedlt requested review from a team, ConX, canaleal and lunatic-fox and removed request for a team October 22, 2023 15:20
Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devicon.json is great, and the SVG is optimized/ uses hex fill. Nice nice.

@Snailedlt Snailedlt merged commit c637bb7 into devicons:develop Oct 24, 2023
6 checks passed
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants