Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Couchbase (original, original-wordmark, plain-wordmark) #1932

Merged
merged 14 commits into from
Nov 1, 2023
Merged

new icon: Couchbase (original, original-wordmark, plain-wordmark) #1932

merged 14 commits into from
Nov 1, 2023

Conversation

SAHIL-KUMAR-EE
Copy link
Contributor

@SAHIL-KUMAR-EE SAHIL-KUMAR-EE commented Oct 24, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1931

Link to prove your SVG is correct and up-to-date.

Couchbase Logo

Snailedlt
Snailedlt requested changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
Welcome to devicons, this is a great first PR!

The icon looks great, though I'm wondering if you could also add the wordmark version :)

devicon.json Outdated Show resolved Hide resolved
@SAHIL-KUMAR-EE SAHIL-KUMAR-EE changed the title new icon: Couchbase (original) new icon: Couchbase (original, original-wordmark) Oct 25, 2023
@SAHIL-KUMAR-EE SAHIL-KUMAR-EE changed the title new icon: Couchbase (original, original-wordmark) new icon: Couchbase (original, original-wordmark, plain, plain-wordmark) Oct 27, 2023
Snailedlt
Snailedlt requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if my previous suggestions were a bit hard to understand. I hope this is better. If not, let me know :)

devicon.json Outdated Show resolved Hide resolved
icons/couchbase/couchbase-plain.svg Outdated Show resolved Hide resolved
@SAHIL-KUMAR-EE
Removed couchbase-plain.svg
268ff07 
File at icons/couchbase/couchbase-plain.svg removed since it is the same icon as couchbase-original.svg without the color.
@SAHIL-KUMAR-EE
Updated devicon.json
77c2b46 
Removed "plain" in SVG section of "couchbase".
Also removed alias for plain-wordmark.svg as it already exists.
@SAHIL-KUMAR-EE SAHIL-KUMAR-EE changed the title new icon: Couchbase (original, original-wordmark, plain, plain-wordmark) new icon: Couchbase (original, original-wordmark, plain-wordmark) Oct 28, 2023
Snailedlt
Snailedlt reviewed Oct 28, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small changes (see the last two commits) to get this PR done. Hope you don't mind :)
Thank you for the contribution! ✔️
Hope to see more! 💯

@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team October 28, 2023 13:18
@Snailedlt Snailedlt added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Oct 28, 2023
weh
weh approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Snailedlt Snailedlt merged commit 32e69f6 into devicons:develop Nov 1, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SAHIL-KUMAR-EE @weh @Snailedlt