Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: maven (plain, plain wordmark) #1945

Merged
merged 3 commits into from
Oct 29, 2023
Merged

update icon: maven (plain, plain wordmark) #1945

merged 3 commits into from
Oct 29, 2023

Conversation

Snailedlt
Copy link
Collaborator

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

This PR is needed in order to fix maven's font. See this preview from the automated PR into draft-release branch: #1944
#1944

@Snailedlt Snailedlt requested review from a team, ConX, weh, canaleal and lunatic-fox and removed request for a team October 29, 2023 15:36
@Snailedlt Snailedlt mentioned this pull request Oct 29, 2023
Closed
@Snailedlt
Copy link
Collaborator Author

image
image
image

@Snailedlt Snailedlt merged commit 306b261 into devicons:develop Oct 29, 2023
5 checks passed
@Snailedlt
Copy link
Collaborator Author

Merging this to get the release along. Feel free to review it even though it's merged, and I'll do another PR to fix any issues

weh
weh reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Snailedlt Snailedlt added hacktoberfest-accepted Accepted to be counted towards Hacktoberfest feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Nov 1, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh left review comments

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Snailedlt @weh