Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: lua (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2033

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

canaleal
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

Used the color #000080 for the font SVGs.

All 3 versions were created as the Original SVGs had 2 colors; Navy for the planet/moon and gray for the orbit path.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 21, 2023
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

i only asked myself, if the "non-wordmark" versions really are official, or needed. but since the plain ones already existed, i think its ok

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team November 23, 2023 10:03
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @weh commented and as far as I see there are no "non-wordmark" versions for this icon.

  • The original version has "Lua" in #ffffff.
    original

Perhaps, we should make these changes:

  • Rename original-wordmark to original, delete original-wordmark. Alias original as original-wordmark.
  • Rename plain-wordmark to plain, delete plain-wordmark. Alias plain as plain-wordmark.
  • Rename line-wordmark to line, delete line-wordmark. Alias line as line-wordmark.

@lunatic-fox lunatic-fox requested a review from weh December 3, 2023 03:42
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️

image
image
image

@Snailedlt Snailedlt merged commit 7cb63f3 into devicons:develop Dec 3, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants