Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: vsphere (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2058

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

canaleal
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

There are different versions of VMware vSphere, with the latest being 8.
The blue color #0091da was used for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 25, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this icon has the registered mark on it. Here goes some suggestions.

original-wordmark
plain-wordmark
line-wordmark

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @lunatic-fox mentioned, the icons here are missing the ® symbol. See the suggestions in his comment :)

Snailedlt
Snailedlt previously approved these changes Dec 5, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
The fonts look great now! 💯
image
image
image
image
image

@Snailedlt Snailedlt requested review from lunatic-fox, a team, ConX and weh and removed request for a team December 5, 2023 15:41
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny small missing newline, the rest is perfect 👍

icons/vsphere/vsphere-plain-wordmark.svg Outdated Show resolved Hide resolved
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
Snailedlt
Snailedlt previously approved these changes Dec 7, 2023
@Snailedlt Snailedlt requested a review from weh December 7, 2023 10:16
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wordmark versions were tilted a little bit to the right.
Fixed! 🔧
image
image

@Snailedlt Snailedlt merged commit c596932 into devicons:develop Dec 17, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants