update icon: xd (original, plain, line) #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canaleal
added
the
feature:icon
This was referenced Nov 27, 2023
lunatic-fox
approved these changes
Nov 30, 2023
lunatic-fox
requested review from
a team,
ConX and
weh
and removed request for
a team
Snailedlt
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Another great PR! 🚀
The only thing I'm wondering about is if these icons could possibly also fit the wordmark requirements. If so we should add wordmark aliases to devicon.json. Let me know what you think @lunatic-fox @canaleal
Anyways, that can be a new PR if we decide to do that :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR is related to #1998
Link to prove your SVG is correct and up-to-date.
Additional Notes
The dark purple color
#470137was used for the font SVGs.