Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: firebase (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2083

Merged
merged 6 commits into from
Dec 23, 2023

Conversation

canaleal
Copy link
Contributor

@canaleal canaleal commented Dec 1, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

The yellow color #ffcc2e was used for the font SVGs and is can be found on the bottom shape of the original svg.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 1, 2023
@lunatic-fox lunatic-fox requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team December 5, 2023 03:48
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR! However I'm not sure that yellow is the right color choice. I feel like the middle orange color (#ffa712) should be chosen instead.
Anecdotally I've found that orange is more commonly used on their website, it's also what I associate with firebase. Another good reason to pick that color imo is that it's a middle-point between the yellow (#ffcc2e) and dark orange (#f6830e) color, and it's more easily visible on white backgrounds, while also being bright enough for dark backgrounds.

Would love a 2nd and 3rd opinion on this though, which is why this is a "comment" and not a "request changes" review. @lunatic-fox @canaleal @weh what do you guys think?

@canaleal
Copy link
Contributor Author

canaleal commented Dec 6, 2023

Honestly, I was little hesitant on choosing yellow for those exact same reasons (Hard to see, prominent on the logo but not the most common color on the website). I think the dark orange is a bit too much, but the middle orange #ffc928 is just right.

@Snailedlt
Copy link
Collaborator

I didn't take a close look at the website, but from just a quick look, it looked like there were multiple different shades of yellow/orange being used.

Sidenote: Another reason is that the dark orange seems to be the "shadow color", and the yellow seems to be the "highlight color". By that logic the light orange color would be the "base color".

@lunatic-fox
Copy link
Contributor

Another great PR! However I'm not sure that yellow is the right color choice. I feel like the middle orange color (#ffa712) should be chosen instead. Anecdotally I've found that orange is more commonly used on their website, it's also what I associate with firebase. Another good reason to pick that color imo is that it's a middle-point between the yellow (#ffcc2e) and dark orange (#f6830e) color, and it's more easily visible on white backgrounds, while also being bright enough for dark backgrounds.

Would love a 2nd and 3rd opinion on this though, which is why this is a "comment" and not a "request changes" review. @lunatic-fox @canaleal @weh what do you guys think?

I like the Firebase Amber which is #ffa000.

Here are the official colors:
Firebase Yellow: #ffca28
Firebase Amber: #ffa000
Firebase Orange: #f57c00

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color needs to be changed to #ffa000, which is Firebase Amber (ref)

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️

@Snailedlt Snailedlt merged commit a04b7df into devicons:develop Dec 23, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants