Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: biome (original, original-wordmark, plain-wordmark, line, line-wordmark) #2108

Merged
merged 5 commits into from
May 25, 2024

Conversation

angelajfisher
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2107

Link to prove your SVG is correct and up-to-date.

Blog post introducing new logo: https://biomejs.dev/blog/roadmap-2024/#new-logo-and-homepage

Official Logo SVG:
Official Logo SVG

Official Wordmark SVG:
Official Wordmark SVG

@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt, canaleal, Panquesito7 and lunatic-fox and removed request for a team January 14, 2024 02:38
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jan 14, 2024
Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and excellent work updating the json! I've marked down some changes.

To maintain a cohesive look, it would be good to update the line-wordmark and line wordmark fills with the #60a5fa color used in the original.svg and plain-wordmark.svg.

The strokes in the line SVGs have to be updated to paths. In inkscape this an can be done by selecting all paths and then using the strokes > paths option.

image

The line-wordmark, plain-wordmark, and original-wordmark have to be scaled to reach the edges of the viewbox.
image

@angelajfisher
Copy link
Author

Hi @canaleal, thank you so much for reviewing my PR and for the detailed feedback! My apologies for the oversights. I've pushed changes to hopefully remedy all of the problem areas, but I'm happy to iterate further if needed.

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, no other major updates required!

I hope you don't mind but I optimized the SVGs to verify how they look on Icomoon.
Thankfully all icons look good and there are no artifacts.
image

Also, we use the following tutorial to optimize the SVGs.

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@angelajfisher
Copy link
Author

Awesome, I appreciate the help and guidance! Thank you so much for allowing me to contribute!

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit e17a024 into devicons:develop May 25, 2024
5 checks passed
@angelajfisher angelajfisher deleted the biome-icons branch May 27, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants