Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: dovecot (original, plain, line) #2125

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

weh
Copy link
Contributor

@weh weh commented Jan 31, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

**This PR closes #2113 **

Link to prove your SVG is correct and up-to-date.

Some thoughts

i am not sure if it is ok to create a non-wordmark version.

Also there are two color variants for commercial and open source versions (See style guide).
I chose the open source color for original.

While editing the devicon.json i got doubts if a e-mail server is even matching our acceptance criteria.
So what do you think @Panquesito7 @Snailedlt @canaleal @lunatic-fox
Btw. if we decide to not add this, we should also close #2112

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team January 31, 2024 10:34
@weh weh mentioned this pull request Feb 1, 2024
1 task
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Feb 17, 2024
@canaleal
Copy link
Contributor

canaleal commented Apr 18, 2024

I couldn't find a non-wordmark version of the logo on their website or style guide, so I suggest we stick with the word-mark version for now.

In terms of its acceptability, I'm somewhat undecided but leaning towards accepting it. Although the tool is essentially an email server, it's heavily utilized by IT professionals, administrators, and developers, which suggests it holds significance within our context.

Also excellent work, icons looks good. 👍

- Rename files and add their correspondent `wordmark` aliases in `devicon.json`.
- Change the default color in `devicon.json`.
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@lunatic-fox lunatic-fox changed the title new icon: dovecot (original-wordmark, plain-wordmark, line-wordmark) new icon: dovecot (original, plain, line) Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants