Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon: cosmosdb (original, original-wordmark) #2140

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

weh
Copy link
Contributor

@weh weh commented Feb 8, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Centered icon in 128x128
  • Optimized images

This PR closes #2134

Notes

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team February 8, 2024 16:28
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall excellent 👍

2 changes needed:

  • (OPTIONAL) Ungroup the paths in the original.svg
  • There's some bottom padding in the original-wordmark.svg

@weh weh requested a review from canaleal February 20, 2024 08:51
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on original.svg 👍

However, there's another issue with original-wordmark.svg. While the padding problem has been resolved, the SVG has been enlarged and is not properly centered.

image

If using inkscape the following steps will help solve the issue:

  1. Select all paths and group them
  2. Press the lock icon in the top right
  3. Set the height to 128 in the input box
  4. Center the SVG horizontally and vertically using the options in the align and distribute menu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found out, that this happened while resizing with https://www.iloveimg.com/resize-image
i will check later what is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i finally fixed this now. Can you please review it again @canaleal :)

@weh weh force-pushed the feature/2134-update-cosmosdb branch from c3508ae to 6a24b87 Compare April 23, 2024 08:44
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants