Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: glitch (original, plain) #2163

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AnshSinghSonkhia
Copy link

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR fixes #2158

Link to prove your SVG is correct and up-to-date.

Home page: https://glitch.me/
Icon (on Simple Icons): https://simpleicons.org/icons/glitch.svg

SVGs

plain-svg original-svg

@Kaamkiya
Copy link

Kaamkiya commented Mar 9, 2024

Thanks for fixing my issue :)

@AnshSinghSonkhia
Copy link
Author

Thanks for fixing my issue :)

@Kaamkiya Thanks for raising it, I'm glad to help you :)

"original",
"plain",
],
"font": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure there's at least 1 font version. In this case, use plain.

"font": []
},
"color": "#000000",
"aliases": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original and plain SVGs do not include the word "glitch". Therefore, they cannot serve as aliases for the wordmark SVGs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add an empty new line to this SVG.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a new line.

Also, I don't see any version of the glitch fish that are all black. I think combining the pink and blue color into a new color would be better than using the all black fish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants