Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: phoenix (original, plain) #217

Closed
wants to merge 5 commits into from
Closed

new icon: phoenix (original, plain) #217

wants to merge 5 commits into from

Conversation

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • At least the plain or line version of the icon is required (since those are required for the icon font)
  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Kartstig Kartstig requested a review from amacado January 6, 2021 17:52
@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 6, 2021

@amacado I added a plain icon per guidelines.

I am not able to figure out the correct fonts to make the wordmark versions

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove phoenix-plain.svg, because I can't see any difference compared to phoenix-original.svg but the svg code does not look very pretty.

I suggested a code change to devicon.json to fulfill our updated requirements. If you could remove the depreceated enable-background="new 0 0 128 128" from the svg I'm happy 👍🏻

Also changed the branch to develop.

devicon.json Outdated Show resolved Hide resolved
@amacado amacado changed the base branch from master to develop January 7, 2021 00:19
@amacado amacado changed the title Add Phoenix icon new icon: phoenix (plain) Jan 7, 2021
@amacado amacado changed the title new icon: phoenix (plain) new icon: phoenix (original) Jan 7, 2021
@amacado amacado removed the stale For PRs that haven't had any activity for a while and old issues label Jan 7, 2021
@Kartstig
Copy link
Contributor Author

Kartstig commented Jan 7, 2021

Done!

@amacado
Copy link
Member

amacado commented Jan 7, 2021

@Kartstig could you resolve the conflichts with devicon.json? Probably you need to merge with current development branch.

Kartstig and others added 5 commits January 8, 2021 11:46
@Kartstig Kartstig requested a review from amacado January 8, 2021 16:47
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 8, 2021
@amacado amacado changed the title new icon: phoenix (original) new icon: phoenix (original, plain) Jan 9, 2021
"name": "phoenix",
"tags": ["framework", "elixir"],
"versions": {
"svg": ["original", "plain"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A font version is missing for phoenix. We need at least one font version to add the icon to our set :)

@amacado amacado added the stale For PRs that haven't had any activity for a while and old issues label Feb 23, 2021
@Panquesito7
Copy link
Member

#551.

@Panquesito7 Panquesito7 closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request - Phoenix Framework Elixir & Phoenix Icons?
4 participants