-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: phoenix (original, plain) #217
Conversation
Kartstig
commented
Jun 8, 2020
- Fixes Icon Request - Phoenix Framework #101
- Fixes Elixir & Phoenix Icons? #33
- From Add various new platforms and languages (elixir, phoenix, arduino, minix, raspberry pi) #102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:
- At least the plain or line version of the icon is required (since those are required for the icon font)
- Modify devicon.json to include the icon (or variations)
- Modify devicon-colors.css to include the colored version of the icon
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hello there, We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves. Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes. Cheers, |
@amacado I added a plain icon per guidelines. I am not able to figure out the correct fonts to make the wordmark versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove phoenix-plain.svg
, because I can't see any difference compared to phoenix-original.svg
but the svg code does not look very pretty.
I suggested a code change to devicon.json
to fulfill our updated requirements. If you could remove the depreceated enable-background="new 0 0 128 128"
from the svg I'm happy 👍🏻
Also changed the branch to develop
.
Done! |
@Kartstig could you resolve the conflichts with devicon.json? Probably you need to merge with current development branch. |
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
"name": "phoenix", | ||
"tags": ["framework", "elixir"], | ||
"versions": { | ||
"svg": ["original", "plain"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A font
version is missing for phoenix
. We need at least one font version to add the icon to our set :)
#551. |