Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon: Dart (original, original-wordmark, line, line-wordmark) #271

Closed
wants to merge 1 commit into from

Conversation

IoanaAlexandru
Copy link

@IoanaAlexandru IoanaAlexandru commented Aug 27, 2020

I initially opened issue #267 to request this icon and you suggested contributing. I'm only a beginner with Illustrator, but I figured why not try?

I wasn't sure what the stroke width should be so I left it as 1pt, but the line versions would look better with a smaller width.

I hope it's okay!

image

@amacado amacado self-requested a review August 29, 2020 08:30
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @IoanaAlexandru, I appreciate your contribution. Some notes why I like to request changes:

  • The lines/corners of all icons should be better aligned, see my screenshot with annotated red quartes
  • The line versions must consist of a single path (try to upload them to https://icomoon.io/app/#/select) and convert them into a font. You are not allowed to get an error message

image

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 29, 2020
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@IoanaAlexandru
Copy link
Author

Sorry, I don't really know how to fix the icons and unfortunately don't have the time to learn. This branch is open to edits from maintainers, so it would be great if you could fix the graphics and add them.

@Panquesito7
Copy link
Member

See #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants