Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: appwrite (plain, original, wordmark) #371

Merged
merged 9 commits into from Jan 19, 2021

Conversation

eldadfux
Copy link
Contributor

@eldadfux eldadfux commented Dec 2, 2020

I've added the original, plain, original-wormark, and plain-wordmark icons for https://appwrite.io/. Give it a check and let me know if there's something I should change.

@eldadfux eldadfux changed the title Added Appwrite icon Added Appwrite icons Dec 2, 2020
@amacado amacado changed the base branch from master to develop December 3, 2020 16:52
@amacado amacado changed the title Added Appwrite icons new icon: appwrite.io [plain, original, wordmark] Dec 3, 2020
@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 3, 2020
@amacado amacado self-requested a review December 12, 2020 14:38
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons looking good! :) Thanks for the contribution. Could you merge the devicon.json with our latest version? :)

@eldadfux
Copy link
Contributor Author

Merged :)

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 12, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons looking good, but we do not them them twice in the set, see my code suggestions 😄

new_icons

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Dec 31, 2020
@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@eldadfux
Copy link
Contributor Author

eldadfux commented Jan 7, 2021

So sorry for the delays, its been a hectic few weeks. I will set myself a reminder to try and finish in in the next couple of weeks!

@Thomas-Boi
Copy link
Member

Thank you for picking up this PR again! Just take your time and we really appreciate it 😄

@Thomas-Boi Thomas-Boi removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger stale For PRs that haven't had any activity for a while and old issues labels Jan 7, 2021
eldadfux and others added 3 commits January 14, 2021 09:07
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
@eldadfux
Copy link
Contributor Author

Seems like I just needed to accept all the code suggestions? @amacado let me know if I missed something...

@eldadfux eldadfux requested a review from amacado January 14, 2021 07:09
@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 19, 2021
@amacado amacado changed the title new icon: appwrite.io [plain, original, wordmark] new icon: appwrite [plain, original, wordmark] Jan 19, 2021
@amacado amacado changed the title new icon: appwrite [plain, original, wordmark] new icon: appwrite (plain, original, wordmark) Jan 19, 2021
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 19, 2021
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, been a little busy. Thanks for the update @eldadfux. appwrite.io will be in the upcomming devicon release! :)

@amacado amacado merged commit 97e6a51 into devicons:develop Jan 19, 2021
@eldadfux
Copy link
Contributor Author

Ohh this is awesome, we're so gonna tweet about it 🤟

@amacado amacado mentioned this pull request Jan 19, 2021
amacado added a commit that referenced this pull request Jan 20, 2021
* Create eleventy-original.svg

* Create eleventy-plain.svg

* Update devicon.json

* Update eleventy-plain.svg

* Update eleventy-original.svg

* new icon: sqlalchemy (plain, original, original-workmark)

* Add font aliase for sqlalchemy

* new icon: microsoftsqlserver (plain, plain-wordmark) (#427)

* new icon sqlserver (plain, plain-woodmark)

* Update icons/sqlserver/sqlserver-plain-wordmark.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update icons/sqlserver/sqlserver-plain.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Rename sqlserver icons to microsoftsqlserver

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* new icon: kubernetes (plain, plain-wordmark) (#424)

* new icon: kubernetes (plain, plain-wordmark)

* Update icons/kubernetes/kubernetes-plain.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update icons/kubernetes/kubernetes-plain-wordmark.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* new icon: rocksdb (plain) (#423)

* new icon: rocksdb (plain)

* Update icons/rocksdb/rocksdb-plain.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* new icon: googlecloud (original, original-wordmark, plain, plain-wordmark) (#428)

* new icon: googlecloud (plain, plain-wordmark, original, original-wordmark)

* Update icons/googlecloud/googlecloud-plain.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update icons/googlecloud/googlecloud-original-wordmark.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update icons/googlecloud/googlecloud-original.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Fix google cloud icons

* Fix googlecloud original

* Remove fill redefinition from google cloud original

* Fix googlecloud alignment (Test)

* Fix googlecloud alignment (test)

* Fix googlecloud alignment (test)

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* new icon: objectivec (plain) (#425)

* new icon: objectivec (plain)

* Update icons/objectivec/objectivec-plain.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* new icon uwsgi (original, plain)

* Cleanup uwsgi icons

* Update devicon.json

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

* Add adobe XD line icon

* Add xd-plain and eps file

* Clean up xd svg file

* Update devicon.json

* new icon: firebase (plain, plain-wordmark) (#461)

* add icon Firebase (plain, plain-wordmark), Closes #204

* new icon: firebase (plain, plain-wordmark)

* update icons

* Add plain-wordmark to firebase fonts

* new icon: flask (original, original-wordmark) (#463)

* Cleanup flask icon

* Improve flask icons

* Update icons/flask/flask-original-wordmark.svg

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

Co-authored-by: moghya <sawantshubham571@gmail.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update devicon.json

* Fixed an error with devicon.json

* Added check script for the icons and fix icons with fill or viewBox issues (#460)

* Added script to check svg fill and viewBox

* Fix cucumber-plain-wordmark

* Fix various fill and viewBox issues in svgs

* Added check for height and width attr

* Added check_svgs workflow

* Fix an issue where the error is not log properly

* Added on push for testing

* Updated trigger so it now runs whenever PR is update

* Added sleep to script to make logs nicer

* Added script that create env var

* Updated the github_env to accomodate ubuntu

* Change format of log and allow filehandler to return Path

* Updated logging messages

* Updated refs for the checkout action

* Make logging nicer

* Updated fix messaging so it's more clear

* fix icons: icons/cucumber/cucumber-plain-wordmark.svg, icons/intellij/intellij-plain-wordmark.svg, icons/jenkins/jenkins-plain.svg, icons/twitter/twitter-original.svg, icons/yunohost/yunohost-plain.svg

* Fix the ref issue of the checkout action and sqlalchemy  (#472)

* Remove head_ref from checkout action

* Fixed the svg errs in sqlalchemy

* Create a monthly script that checks all svgs

* Python now print traceback

* Updated file names in check_svgs_on_pr

* Remove deprecated and unused svg syntax

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Remove deprecated and unused svg syntax

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update svg fill, remove unused class

* Change comment action to a new action

* Add guideline about squash merging

As the result of discussion #470 update guidelines with squash merging

* Redo the workflow archs so we can comment on pr

* Moved check_svgs_monthly to draft

* Added working workflow file

* Changed to file read action

* new icon: appwrite (plain, original, wordmark) (#371)

* Added Appwrite icon

* Fixed wrong JSON input

* Fixed JSON style

* Fixed indent

* Update devicon.json

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>

* bot:build new icons, icomoon.json and devicon.css (#486)

* fix bash-plain (#451) (#453)

Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com>

* Built new icons, icomoon.json and devicon.css

Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com>
Co-authored-by: amacado <amacado@users.noreply.github.com>

* Removed 'default fall back icon' from build_icons.yml

Co-authored-by: Tylen St Hilaire <28753109+tylensthilaire@users.noreply.github.com>
Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Withee Poositasai <witheep@gmail.com>
Co-authored-by: moghya <sawantshubham571@gmail.com>
Co-authored-by: Thomas Bui <thomasbui198@gmail.com>
Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: amacado <amacado@users.noreply.github.com>
@eldadfux
Copy link
Contributor Author

Thanks guys!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants