Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Bash (original, plain) #415

Merged
merged 9 commits into from
Jan 1, 2021

Conversation

EnisMulic
Copy link
Contributor

I took the bash SVG from #170 and cleaned it up in so it doesn't use inline styles, not sure if I did this correctly.

@amacado amacado linked an issue Dec 30, 2020 that may be closed by this pull request
@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Dec 30, 2020
devicon.json Outdated Show resolved Hide resolved
icons/bash/bash-original.svg Outdated Show resolved Hide resolved
@amacado amacado changed the title Add new icon Bash (Original, Plain), Closes #303 new icon: Bash (original, plain) Dec 30, 2020
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Dec 30, 2020
@Thomas-Boi
Copy link
Member

Hi @EnisMulic ,

Unfortunately, we are running into some issues checking your SVGs. It seems that your forked repo is from an older version of our master branch. In order for us to check your icons, please pull our latest commit from our develop to your fork.

You might find this link useful to update your repo.

Cheers,
Thomas

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 31, 2020
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Dec 31, 2020
devicon.json Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 1, 2021
@EnisMulic
Copy link
Contributor Author

EnisMulic commented Jan 1, 2021

Any tips on how to fix this upload issue, it seems to work fine when I do it manually
image

@Thomas-Boi
Copy link
Member

Hello @EnisMulic ,

Sorry for the long wait. It seems that we ran into a very peculiar error that we never see before. As you might know, our repo use icomoon to create our icons. This is a browser and not an API, which means that we have to be precise in choosing which element to click etc...

Normally, when we upload icons, we would remove its colors entirely using Icomoon. This is available here:
image

When we upload your icon, we see this instead:
image

This has never happened before so our script didn't know how to handle it. In fact, I would not be surprised if the Icomoon team just upload a new version of their app which might have cause this to happen.

image

Any how, I had to clone your repo and test it locally to fix this issue. I have also seen your icon and it looks great to me. Thus, if you want, we can accept your PR right now. @amacado what do you think? I will open another PR that contain the fix for this issue.

@amacado amacado merged commit a0d90ea into devicons:develop Jan 1, 2021
@amacado amacado mentioned this pull request Jan 1, 2021
@Thomas-Boi
Copy link
Member

Thomas-Boi commented Jan 1, 2021

@EnisMulic congratulation, you are our first PR for 2021. Happy New Year and thanks for your work 🎉

@EnisMulic EnisMulic deleted the feature/icon/bash branch January 12, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: Bash
3 participants