-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: r (original, plain) #491
Conversation
Hi! Everything looks great. Good job! Have a nice day, |
Hello @jakob-r for contributing Update: It worked after a couple of tries, see #491 (comment) |
I uploaded the icons myself to check them, here are the results:
Both icons are a little off-centered (top-bottom): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting change to fix the top/bottom spacing.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Hi @amacado, I don't know what's causing these errors. It seems so random that I feel it might be a multi-threading or multi-processing issue. I'll search around and see if this has happened before. At the very least, we know that the new workflows work 😄. |
@Thomas-Boi I just wanted to let you know that this error still occurs sometimes ;-) My guess is that it depends on the server which executes the action. I assume that icomoon blocks an ip (f.e. when many requests occur from the same machine in a short period) and since we are sharing the server where the action is executed (i guess?) this error could be caused by other actions which run independly from our action.. This would be an explaination why this error seems to occur randomly. |
Oh right, I forgot that this was our working theory for now. I wonder if we should write another script that retry the connection. Let's just keep an eye on this for now. |
So you want it centered or is there a certain baseline? I tried to center the circle to give it a more balanced look. |
On the left my plain version - wher I substracted a part of the circle so the R becomes more visible. I was hoping this kind of modification would be ok? |
@jakob-r feel free to re-request a review as soon as you commited the centering of the icon :) |
I centered the icon as requested. |
Hi! Everything looks great. Good job! Have a nice day, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jakob-r! r
will be included in the next release!
Icon for the R programming language: https://en.wikipedia.org/wiki/R_%28programming_language%29