Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: r (original, plain) #491

Merged
merged 2 commits into from
Feb 19, 2021
Merged

new icon: r (original, plain) #491

merged 2 commits into from
Feb 19, 2021

Conversation

jakob-r
Copy link
Contributor

@jakob-r jakob-r commented Feb 15, 2021

image

Icon for the R programming language: https://en.wikipedia.org/wiki/R_%28programming_language%29

@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Feb 16, 2021
@amacado amacado self-requested a review February 16, 2021 08:10
@amacado amacado linked an issue Feb 16, 2021 that may be closed by this pull request
@amacado amacado changed the title new icon:r (original, plain) new icon: r (original, plain) Feb 16, 2021
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 16, 2021
@amacado
Copy link
Member

amacado commented Feb 16, 2021

Hello @jakob-r for contributing R. I know this icon was requested by many people.
I fixed the title of this pull request to make our bot:peek command work (a space was missing, so it failed on first try). @Thomas-Boi: It also failed a couple of times because of the known No connection could be made because the target machine actively refused it. (os error 10061) error). I will try it again later this day.

Update: It worked after a couple of tries, see #491 (comment)

@amacado
Copy link
Member

amacado commented Feb 16, 2021

I uploaded the icons myself to check them, here are the results:

image

plain and original look very similar, but they still differ so I think it's fine to add them both.

Both icons are a little off-centered (top-bottom):
image
@jakob-r maybe you can have a look at that?

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to fix the top/bottom spacing.

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images\nImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Feb 16, 2021
@Thomas-Boi
Copy link
Member

Hi @amacado,

I don't know what's causing these errors. It seems so random that I feel it might be a multi-threading or multi-processing issue. I'll search around and see if this has happened before.

At the very least, we know that the new workflows work 😄.

@amacado
Copy link
Member

amacado commented Feb 16, 2021

I don't know what's causing these errors. It seems so random that I feel it might be a multi-threading or multi-processing issue. I'll search around and see if this has happened before.

@Thomas-Boi I just wanted to let you know that this error still occurs sometimes ;-) My guess is that it depends on the server which executes the action. I assume that icomoon blocks an ip (f.e. when many requests occur from the same machine in a short period) and since we are sharing the server where the action is executed (i guess?) this error could be caused by other actions which run independly from our action.. This would be an explaination why this error seems to occur randomly.

@Thomas-Boi
Copy link
Member

I assume that icomoon blocks an ip (f.e. when many requests occur from the same machine in a short period) and since we are sharing the server where the action is executed (i guess?)

Oh right, I forgot that this was our working theory for now. I wonder if we should write another script that retry the connection. Let's just keep an eye on this for now.

@jakob-r
Copy link
Contributor Author

jakob-r commented Feb 18, 2021

Requesting change to fix the top/bottom spacing.

So you want it centered or is there a certain baseline? I tried to center the circle to give it a more balanced look.

@jakob-r
Copy link
Contributor Author

jakob-r commented Feb 18, 2021

I uploaded the icons myself to check them, here are the results:

image

plain and original look very similar, but they still differ so I think it's fine to add them both.

Both icons are a little off-centered (top-bottom):
image
@jakob-r maybe you can have a look at that?

On the left my plain version - wher I substracted a part of the circle so the R becomes more visible. I was hoping this kind of modification would be ok?
The right is original just without colors.
So from my point of view this would be ok.

@amacado
Copy link
Member

amacado commented Feb 18, 2021

@jakob-r feel free to re-request a review as soon as you commited the centering of the icon :)

@jakob-r
Copy link
Contributor Author

jakob-r commented Feb 19, 2021

@jakob-r feel free to re-request a review as soon as you commited the centering of the icon :)

I centered the icon as requested.

@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@amacado amacado self-requested a review February 19, 2021 14:44
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 19, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

![Peeked Icons (top left)](Imgur Images)

Here are the zoomed-in screenshots of the added icons:
Imgur Images\nImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jakob-r! r will be included in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: R programming language
3 participants