Updated the logging of the actions #509
Conversation
|
Hi! I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue. Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience. Cheers, |
Thomas-Boi
force-pushed
the
thomas/feature/actionMessageUpdate
branch
from
e8b50e5
to
917a5fd
Compare
This comment has been minimized.
This comment has been minimized.
Thomas-Boi
force-pushed
the
thomas/feature/actionMessageUpdate
branch
from
917a5fd
to
565eda9
Compare
This comment has been minimized.
This comment has been minimized.
Thomas-Boi
force-pushed
the
thomas/feature/actionMessageUpdate
branch
from
565eda9
to
3cfedf7
Compare
|
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong: For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 馃槪. Until then, I can only point them out. |
Thomas-Boi
force-pushed
the
thomas/feature/actionMessageUpdate
branch
from
3cfedf7
to
2249c46
Compare
|
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong: For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 馃槪. Until then, I can only point them out. |
|
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong: For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 馃槪. Until then, I can only point them out. |
There was a problem hiding this comment.
@Thomas-Boi thanks for improving the script! I approve this pull request!
|
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong: For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 馃槪. Until then, I can only point them out. |
| @@ -54,7 +54,7 @@ jobs: | |||
| I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using [icomoon.io](https://icomoon.io/app/#/select). | |||
| Here is the result below: | |||
|
|
|||
|  | |||
| {0} | |||
|
|
|||
| Here are the zoomed-in screenshots of the added icons: | |||
There was a problem hiding this comment.
When you add more than two icons for the font versions, it adds up an \n in the GitHub comment:
There was a problem hiding this comment.
Has this been fixed yet? Or is it fixed in this PR? 馃槃
There was a problem hiding this comment.
@Panquesito7 a few seconds too late. I will create a new issue based on your report! Thanks! 馃憤馃徎
Hi,
This PR intends to fix the logging for the Peek Bot Action:
And provide the path name for the Check SVG Action. Right now, it's just the name:
Now:
This should print out the whole path:
EDIT:
This now contains a fix to the
post_check_svgs_comment.ymlworkflow that will run when there are no SVGs to check and post the wrong message (see the below image and GitHub message):The fix:
NOTE: The change will only take effect when the yaml file is merged into master (recall the workflow_run restriction) so it'd be great if we can put this in the next release.
Cheers,