Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build bot now check both the PRs and the devicon.json for icons to be build #686

Merged
merged 3 commits into from Jun 21, 2021

Conversation

Thomas-Boi
Copy link
Member

This PR contains:

  • Build bot will now check both the PRs (new feature) and compare the devicon.json to the icomoon.json (old feature) to find icons to be build.
  • The stale.yml has been moved to the draft folder since we do not need it for now. We can reuse it later if we wish to though.

Test:

I ran the build bot after the upgrade. Since we just have a new release, the PRs would yield nothing. However, comparing the devicon.json and icomoon.json did yield arduino.
image

Fixes #684

@Thomas-Boi Thomas-Boi added devops Use this label for devops related enhancements enhancement labels Jun 18, 2021
@amacado amacado linked an issue Jun 18, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member Author

Also, for some reason the check-svg bot is failing here. There's an internal error apparently. I think we just keep an eye on this for now

@Thomas-Boi Thomas-Boi merged commit 8a6bab3 into develop Jun 21, 2021
@Thomas-Boi Thomas-Boi deleted the thomas/buildBotFix branch June 26, 2021 05:03
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Arduino icon broken
2 participants