Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: storybook (original, original-wordmark, plain, plain-wordmark) #799

Merged
merged 16 commits into from Aug 16, 2021

Conversation

jonlima2018
Copy link
Contributor

issue #266

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 11, 2021
devicon.json Outdated Show resolved Hide resolved
icons/storybook/storybook-original-wordmark.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-original.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-plain.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-original-wordmark.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-original.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/storybook/storybook-plain.svg Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 12, 2021
@github-actions

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the S transparent instead of solid white in all icons.

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 12, 2021
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @jonlima2018! Thank you for your contribution! 😄👍🎉

@Thomas-Boi
Copy link
Member

Hi @jonlima2018,

The icons look great! Thank you for your work.

Unfortunately, we won't be accepting icons PR until the next release. This is because we are upgrading our peek-bot and we want to ensure that your icons fit our new standards.

Please wait until the release comes out. Once that's out, we will look at this PR again and hopefully merge it.

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 16, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look good! Thank you @jonlima2018 and welcome to the repo.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, @jonlima2018! You did great to be your first contribution here! Congratulations, and thank you! We hope you keep contributing. 😄👍🎉

@Thomas-Boi Thomas-Boi merged commit fd99e37 into devicons:develop Aug 16, 2021
This was referenced Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants