Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/fix the pull request template #803

Merged
merged 1 commit into from
Aug 11, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 18 additions & 25 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,45 +1,38 @@
---
name: Pull Request Template
about: Add a new icon or feature to the repo.
title: 'New Icon/Feature: [NAME]'
assignees: ''

---
# New Icon Section
# **New icon section**

<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Feature** section below. -->
<!-- If you are adding a new icon, follow the steps listed here, and delete the **New feature** section below. -->

## Double check these details before you open a PR

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [] PR's base is the `develop` branch.
- [] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)
- [ ] PR does not match another non-stale PR currently opened
- [ ] PR name matches the format *new icon: <i>Icon name</i> (<i>versions separated by comma</i>)*. More details [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#overview)
- [ ] The PR's base is the `develop` branch.
- [ ] Your icons are inside a folder as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#organizational-guidelines)
- [ ] SVG matches the standards laid out [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#svgStandards)
- [ ] A new object is added in the `devicon.json` file as seen [here](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#-updating-the-deviconjson-)

<!-- Refer to the [contributing](https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon) guidelines for more details. -->
<!-- Refer to the contributing guidelines for more details https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#contributing-to-devicon -->

## Link to prove your SVG is correct and up-to-date

## Link to prove your SVG is correct and up-to-date.
<!-- Link to an official page/wiki goes here. Anything that proves your SVGs are the correct ones. -->

---
# New Feature Section
# **New feature section**

<!-- If you are adding a new icon, follow the steps listed here, and delete the **New Icon** section above. -->
<!-- If you are adding a new feature, follow the steps listed here, and delete the **New icon** section above. -->

## Double check these details before you open a PR**
## Double check these details before you open a PR

<!-- Tick the checkboxes to ensure you've done everything correctly -->
- [] PR does not match another non-stale PR currently opened
- [] PR name matches the format *New Feature: brief description of feature*

- [ ] PR does not match another non-stale PR currently opened
- [ ] PR name matches the format *New Feature: a brief description of feature*

## This PR adds/fixes...
## This PR adds/fixes

<!-- List your features here and the benefits they bring. -->

## Notes

<!-- List anything note-worthy here (potential issues, this needs to be merged to `master` before working, etc.). -->
<!-- List anything note-worthy here (potential issues, this needs to be merged to `develop` before working, etc.). -->