Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: msdos (original, plain, line) #827

Merged
merged 4 commits into from Aug 30, 2021
Merged

update icon: msdos (original, plain, line) #827

merged 4 commits into from Aug 30, 2021

Conversation

MichielPater
Copy link
Contributor

This PR adds/fixes

  • msdos icon: removed plain version from font for now as discussed in previous PR.

@Thomas-Boi
Copy link
Member

Hey @MichielPater,

I'm guessing that the plain version doesn't fit your standards?
image

I think it doesn't look as good as the line version either. Perhaps let's remove the plain file as well along with your current change?

@MichielPater
Copy link
Contributor Author

Oh I thought the SVG looked good on the website, just the font looked different!

@Thomas-Boi Thomas-Boi changed the title Update msdos update icon: msdos (original, plain, line) Aug 30, 2021
@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 30, 2021
Thomas-Boi
Thomas-Boi approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. In that case, I'll just update your PR so our bot can remove the plain version in the next build.

@Thomas-Boi Thomas-Boi merged commit 1a14488 into devicons:develop Aug 30, 2021
This was referenced Sep 7, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

Assignees
No one assigned
Labels
enhancement feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichielPater @Thomas-Boi @Panquesito7