dos auto-map update #313
Open
dos auto-map update #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One way to handle the Super Mario Kart case could be to just map to both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOS will now auto-map to the
00-3F:5F00-5FFF + 80-BF:5F00-5FFFarea if not otherwise specified in the .xml manifest file. This fixes issues with Yoshi's Island tools and CCP testing, however it does not fix the issues with Super Mario Kart's00-3F:7F00-7FFF + 80-BF:7F00-7FFFmapping. This still needs to be modified via manual editing of the ROM, or by changing the manifest file appropriately to map.For now, temporarily have the
has_dosvariable set to true automatically incommon/nall/snes/cartridge.hpp, however this can be changed later if there are any other issues that arise with mapping.Removed the
dos_mappedvariable, as this did not accomplish what it was intended to do.