remove chart button for location comparison #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mariamiah
commented
Apr 16, 2020
•
mariamiah
commented
- Allows user to remove a chart from the location comparison template.
edwinmp
requested changes
Apr 18, 2020
Comment on lines
18
to
19
| onRemoveChart: (index: number) => void; | ||
| index: number; |
There was a problem hiding this comment.
I need u to implement this without passing the index as a prop ... this component doesn't need to know about indexes, not even in the onRemoveChart prop
mariamiah
force-pushed
the
feature/remove-chart-button
branch
from
d469aad
to
8baa535
Compare
edwinmp
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.