New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordPress Coding Standards #1
Comments
I made a PR fixing some of the messages thrown by the WordPress standard and PHPCS. I can spend a little more time on more of the issues in the coming days however there are a few things I spotted that would need reworked to silence the messages. I'll open additional issues for those items if I have time :) |
Thanks, I appreciate it 🙌 I'll check the PR out asap and get it merged |
No sweat 👍 I kept the plugin installed on my test site and rechecked it was still working between changes - but it is not extensively tested so merge with care lol Due to many line ending changes the diff reports here don't make it clear initially what code is changed :s Have you considered also adding unit tests and enabling Travis to test commits/PRs? Maybe while I'm here, and in the spirit of hacktoberfest :D, I could look at adding a starting point for some of that as well if you are interested. |
@pattonwebz definitely willing to help with unit-tests. With WP CLI you can generate a fully functional starting point with this command:
|
@lucprincen if you have time to make a start on adding in some tests I'll join in when I get some spare time :) |
@lucprincen @pattonwebz as a developer who knows very little about unit tests, I welcome any help you have the time to give 🙌💯 |
I am working through each release to go over every file in the plugin and bring all coding up to WordPress Coding Standards.
The goal is to have all files done by the release of Version 2.0
The text was updated successfully, but these errors were encountered: