Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devise-security.gemspec #261

Closed
wants to merge 1 commit into from
Closed

Conversation

dillonwelch
Copy link
Contributor

Ensure required ruby version matches what we officially support. Follow up to #189.

Ensure required ruby version matches what we officially support. Follow up to #189.
@dillonwelch dillonwelch added the #️⃣.#️⃣ Minor added functionality in a backwards-compatible manner label Dec 31, 2020
@dillonwelch dillonwelch added this to the 0.15.0 milestone Dec 31, 2020
@coveralls
Copy link
Collaborator

coveralls commented Jan 1, 2021

Coverage Status

Coverage increased (+0.7%) to 97.58% when pulling 15a12a7 on ruby-version-support into 9b8aafa on master.

@olbrich
Copy link
Contributor

olbrich commented Jan 1, 2021

There is a difference between a required ruby version and a supported one. I do not think we should bump the required ruby version unless we start using a language feature that is not supported by an older version. If we update it then anyone using this gem on ruby 2.4 will not be able to install and use it even if all we did was stop supporting that version. I think we should abandon this change unless there is a known incompatibility with 2.3 or 2.4.

@dillonwelch
Copy link
Contributor Author

So the concern I had is that we haven't been running tests since April so there very well could be an incompatibility that we won't find out about until we push out the new version. I wasn't sure how to resolve that except by requiring a newer version.

@olbrich
Copy link
Contributor

olbrich commented Jan 1, 2021

We don't support the old versions, but we also don't want to deliberately break it for anyone who might be using them either. Making this change would move us from 'might not work on older ruby versions' to "won't even install in older versions". I'd rather not force that unless we know for sure that it's a problem. We aren't going to run tests against the older versions to detect it since we aren't supporting them anymore, but if someone using an older version were to report a bug indicating that it's not compatible with 2.3 or 2.4, then my response would be to require a newer ruby version instead of trying to fix the bug.

@dillonwelch
Copy link
Contributor Author

That makes a lot of sense to me. I like it. Thanks for the input.

@dillonwelch dillonwelch closed this Jan 1, 2021
@dillonwelch dillonwelch deleted the ruby-version-support branch January 1, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#️⃣.#️⃣ Minor added functionality in a backwards-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants