Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete outdated controller patches #403

Conversation

vlad-psh
Copy link
Contributor

Seems like after captcha and security_question was refactored to be executed as a before_action (commit 1546b8a), we have a bunch of outdated controllers patches left in the lib/devise/security/patches.

Those aren't being used anywhere, so we can safely remove them.

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2022

Coverage Status

Coverage decreased (-0.3%) to 98.146% when pulling f13bee5 on vlad-psh:vlad-psh/delete-outdated-controller-patches into 00175d2 on devise-security:master.

@dillonwelch dillonwelch merged commit 8df7d64 into devise-security:master Sep 9, 2022
@olbrich olbrich added this to the 0.18.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants