Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: buggy compose_nodes, drops HaloSpots #1723

Closed
georgebisbas opened this issue Jul 13, 2021 · 0 comments · Fixed by #1673
Closed

compiler: buggy compose_nodes, drops HaloSpots #1723

georgebisbas opened this issue Jul 13, 2021 · 0 comments · Fixed by #1673

Comments

@georgebisbas
Copy link
Contributor

buggy compose_nodes, drops HaloSpots to the floor thus leading to wrong number of collapsed loops

MFE:

from devito import configuration
configuration['language'] = 'C'
configuration['platform'] = 'bdw'  # Optimize for an Intel Broadwell
configuration['opt-options']['par-collapse-ncores'] = 1  # Maximize use loop collapsing
from sympy import sin
from devito import Eq, Grid, Operator, Function, TimeFunction
grid = Grid(shape=(80, 80, 80))
f = Function(name='f', grid=grid)
u = TimeFunction(name='u', grid=grid, space_order=4)
eq = Eq(u.forward, f**2*sin(f)*u.dy.dy)
op1_omp = Operator(eq, opt=('blocking', 'openmp'))

Code is using collapse(3) instead of collapse(1)

#1673 solves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant