Updates to vib_gen notebook and accompanying python files #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 17 17
======================================
Misses 17 17 Continue to review full report at Codecov.
|
|
Hi, have you tested the implementation somehow? |
|
I ran the test suite for vib_gen and it passed all tests iirc. You might want to pull it and double check though. |
EdCaunt
force-pushed
the
edc-vib-gen
branch
from
0c9df05
to
cdb8ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devito-fied the solver used for this section and removed irrelevant details from the text relating to the original code. Currently no changes to the exercises.