Unit test to Schema and Fields Trait #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dersonsena
force-pushed
the
schema-unit-test
branch
from
776a1c1
to
deb05b1
Compare
dersonsena
force-pushed
the
schema-unit-test
branch
from
deb05b1
to
43f64a3
Compare
wilcorrea
reviewed
Jun 15, 2021
src/Agnostic/Schema.php
Outdated
| @@ -147,7 +147,7 @@ private function configureField(string $key, object $field): void | |||
| * @noinspection ReturnTypeCanBeDeclaredInspection | |||
| * @noinspection PhpMissingReturnTypeInspection | |||
| */ | |||
| public function newQuery($excludeDeleted = true) | |||
| public function newQuery(bool $excludeDeleted = true) | |||
There was a problem hiding this comment.
Eu acho que isso daqui sobrescreve um método do eloquent, vou precisar testar para ver se não quebra a classe
There was a problem hiding this comment.
@wilcorrea você fala da tipagem? Acredito que isso não sobrescreve. Faço isso direto com outras coisas rsrsrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.