Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

center content horizontally #67

Closed
devkennyy opened this issue Jul 16, 2022 · 4 comments · Fixed by #83
Closed

center content horizontally #67

devkennyy opened this issue Jul 16, 2022 · 4 comments · Fixed by #83
Labels
good first issue Beginner friendly issues. You do not need permission to work on these.

Comments

@devkennyy
Copy link
Owner

content is no longer horizontally centred after the navbar was introduced.
@devkennyy devkennyy added the good first issue Beginner friendly issues. You do not need permission to work on these. label Jul 16, 2022
@Shabbyconnor
Copy link
Collaborator

Shabbyconnor commented Jul 17, 2022 •
edited

I can't seem to recreate this. Would you mind posting a screenshot?
Could it have been caused by the button that was since removed in #78?

@devkennyy
Copy link
Owner Author

You can't seem to recreate what exactly?

@Shabbyconnor
Copy link
Collaborator

Shabbyconnor commented Jul 17, 2022 •
edited

I can't recreate the centering issue you described. Everything seems centered to me

@devkennyy
Copy link
Owner Author

devkennyy commented Jul 17, 2022 •
edited

image

After the addition of the navbar, all content was pushed down equal to the height of the navbar. We need to neutralise that by creating a negative margin. The center of the box needs to be at the true center of the page. I hope you understand 😅

@Shabbyconnor Shabbyconnor mentioned this issue Jul 17, 2022
Merged
Shabbyconnor added a commit to Shabbyconnor/rungeon that referenced this issue Jul 17, 2022
@Shabbyconnor
Merge branch 'master' into devkennyy#67-center-content
68991d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Beginner friendly issues. You do not need permission to work on these.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: align content vertically Shabbyconnor/rungeon
2 participants
@devkennyy @Shabbyconnor